Adding back the build-secret to the e2e test.
#232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decision to remove it was a mistake. It was confused with `imageRepoSecret`. The build arg is supposed to be available to the `build` Dockerfile at `/run/secrets/build-secret/filename`. Signed-off-by: Yoni Bettan <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
size/S
|
/cc @qbarrand |
|
FYI @enriquebelarte |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Jun 2, 2023
…kubernetes-sigs#350) The decision to remove it was a mistake. It was confused with `imageRepoSecret`. The build arg is supposed to be available to the `build` Dockerfile at `/run/secrets/build-secret/filename`. Signed-off-by: Yoni Bettan <[email protected]> Signed-off-by: Yoni Bettan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision to remove it was a mistake. It was confused with
imageRepoSecret.The build arg is supposed to be available to the
buildDockerfile at/run/secrets/build-secret/filename.Signed-off-by: Yoni Bettan [email protected]