Skip to content

Add a script generating files for OperatorHub.io #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2023
Merged

Add a script generating files for OperatorHub.io #302

merged 1 commit into from
Jun 19, 2023

Conversation

qbarrand
Copy link
Contributor

Make a few adjustements to the base CSVs.

/cc @ybettan

@k8s-ci-robot k8s-ci-robot requested a review from ybettan February 14, 2023 10:15
@netlify
Copy link

netlify bot commented Feb 14, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit ce3dd98
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/64902dc3400cc4000899bde1
😎 Deploy Preview https://deploy-preview-302--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 77.68% // Head: 77.68% // No change to project coverage 👍

Coverage data is based on head (4e80757) compared to base (a16e9a0).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   77.68%   77.68%           
=======================================
  Files          26       26           
  Lines        2783     2783           
=======================================
  Hits         2162     2162           
  Misses        516      516           
  Partials      105      105

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erusso7
Copy link
Contributor

erusso7 commented Feb 14, 2023

LGTM 👍

ybettan
ybettan reviewed Feb 14, 2023
View reviewed changes
@qbarrand
Copy link
Contributor Author

/hold
Will make this a Makefile target.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

@qbarrand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kernel-module-management-test-deploy 4e80757 link true /test pull-kernel-module-management-test-deploy

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

qbarrand pushed a commit to qbarrand/kernel-module-management that referenced this pull request Jun 2, 2023
@yevgeny-shnaidman
Fixing FIRWARE files/directories loading (kubernetes-sigs#302)
f80f06a 
Currently the firmware path defined in the Module CR is copied
into the /var/lib/firmware host path, including the the rightmost
directory. Since customed firmware base loading directory for kernel modules
is /var/lib/firmware, it means that kernel modules that are expecting their firmware
to be located unnder base path (/var/lib/firmware) cannot be run, since current implementation
will always contain at leas one additional directory under /var/lib/firmware.
This PR changes implementation, so that, if needed, firmware file can be copied directly under
the base path (/var/lib/firmware)
@qbarrand qbarrand force-pushed the operator-hub-generator branch from 4e80757 to e1ead56 Compare June 16, 2023 13:32
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2023
@qbarrand qbarrand force-pushed the operator-hub-generator branch from e1ead56 to 9444d40 Compare June 16, 2023 15:02
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2023
@qbarrand qbarrand force-pushed the operator-hub-generator branch from 9444d40 to 88f4770 Compare June 16, 2023 15:12
@qbarrand
Copy link
Contributor Author

@yevgeny-shnaidman @ybettan PTAL

ybettan
ybettan reviewed Jun 18, 2023
View reviewed changes
ybettan
ybettan reviewed Jun 18, 2023
View reviewed changes
CONTRIBUTING.md

Then, use the contents of those directories to create new versions in
[k8s-operatorhub/community-operators](https://github.com/k8s-operatorhub/community-operators).
Only one operator should be affected per pull request; create separate PRs if you want to update both KMM bundles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that? Why can't we make a change to both KMM and KMM-hub in a single PR?
Adding a new feature to hub&spoke will probably modify both KMM and KMM-hub.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checklist when creating a new PR mentions this limitation.

Copy link
Contributor

@ybettan ybettan Jun 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean PRs to https://github.com/k8s-operatorhub/community-operators? Do you have some link to the checklist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checklist is the default PR template. See k8s-operatorhub/community-operators#2858 for an example

ybettan
ybettan reviewed Jun 18, 2023
View reviewed changes
ybettan
ybettan reviewed Jun 18, 2023
View reviewed changes
@qbarrand qbarrand force-pushed the operator-hub-generator branch from 88f4770 to dd967a9 Compare June 19, 2023 09:36
ybettan
ybettan reviewed Jun 19, 2023
View reviewed changes
CONTRIBUTING.md Outdated
First, generate all manifests:

```shell
make operator-hub-release IMAGE_TAG=<RELEASE_TAG> VERSION=<VERSION_NUMBER>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make operator-hub-release IMAGE_TAG=<RELEASE_TAG> VERSION=<VERSION_NUMBER>
make operatorhub-release IMAGE_TAG=<RELEASE_TAG> VERSION=<VERSION_NUMBER>

@qbarrand
Add a script generating files for OperatorHub.io
ce3dd98 
Make a few adjustements to the base CSVs.
@qbarrand qbarrand force-pushed the operator-hub-generator branch from dd967a9 to ce3dd98 Compare June 19, 2023 10:28
@ybettan
Copy link
Contributor

ybettan commented Jun 19, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2023
@qbarrand
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 936ec3a into kubernetes-sigs:main Jun 19, 2023
@qbarrand qbarrand deleted the operator-hub-generator branch June 19, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybettan ybettan ybettan left review comments

Assignees

@ybettan ybettan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qbarrand @k8s-ci-robot @codecov-commenter @erusso7 @ybettan