Skip to content

Separate in-cluster build and image existence verification #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yevgeny-shnaidman
Copy link
Contributor

This PR removes the image existance verification from
Sync API of the build package and moves it into the
handleBuild function of the module reconcilier(prior
to calling the Sync API)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 5, 2022
@yevgeny-shnaidman
Copy link
Contributor Author

/cc @qbarrand
/cc @ybettan

@k8s-ci-robot
Copy link
Contributor

@yevgeny-shnaidman: GitHub didn't allow me to request PR reviews from the following users: ybettan.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @qbarrand
/cc @ybettan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

Codecov Report

Base: 72.58% // Head: 72.90% // Increases project coverage by +0.32% 🎉

Coverage data is based on head (5aab29c) compared to base (1b7f0b3).
Patch coverage: 63.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   72.58%   72.90%   +0.32%     
==========================================
  Files          15       16       +1     
  Lines        1583     1587       +4     
==========================================
+ Hits         1149     1157       +8     
+ Misses        378      371       -7     
- Partials       56       59       +3     
Impacted Files Coverage Δ
internal/build/helper.go 0.00% <ø> (ø)
internal/module/helper.go 0.00% <0.00%> (ø)
main.go 4.42% <0.00%> (ø)
controllers/module_reconciler.go 68.66% <73.91%> (+5.33%) ⬆️
internal/build/job/manager.go 76.66% <100.00%> (-5.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yevgeny-shnaidman yevgeny-shnaidman force-pushed the yevgeny/MGMT-11893 branch 2 times, most recently from 2d24d10 to cc8f852 Compare September 6, 2022 09:24
This PR removes the image existance verification from
Sync API of the build package and moves it into the
handleBuild function of the module reconcilier(prior
to calling the Sync API)
@k8s-ci-robot
Copy link
Contributor

@yevgeny-shnaidman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kernel-module-management-check-commits-count 058e80c link false /test pull-kernel-module-management-check-commits-count

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qbarrand
Copy link
Contributor

qbarrand commented Sep 6, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 071840d into kubernetes-sigs:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants