-
Notifications
You must be signed in to change notification settings - Fork 34
Separate in-cluster build and image existence verification #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate in-cluster build and image existence verification #33
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yevgeny-shnaidman: GitHub didn't allow me to request PR reviews from the following users: ybettan. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
02a50fb
to
5aab29c
Compare
Codecov ReportBase: 72.58% // Head: 72.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 72.58% 72.90% +0.32%
==========================================
Files 15 16 +1
Lines 1583 1587 +4
==========================================
+ Hits 1149 1157 +8
+ Misses 378 371 -7
- Partials 56 59 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2d24d10
to
cc8f852
Compare
This PR removes the image existance verification from Sync API of the build package and moves it into the handleBuild function of the module reconcilier(prior to calling the Sync API)
cc8f852
to
058e80c
Compare
@yevgeny-shnaidman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
This PR removes the image existance verification from
Sync API of the build package and moves it into the
handleBuild function of the module reconcilier(prior
to calling the Sync API)