Skip to content

softdep: use a template #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

softdep: use a template #387

wants to merge 1 commit into from

Conversation

qbarrand
Copy link
Contributor

@qbarrand qbarrand commented May 2, 2023

Make the code generating the softdep config slightly more readable.

/cc @yevgeny-shnaidman

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 2, 2023
@netlify
Copy link

netlify bot commented May 2, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit ad0525d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/6450e5d5e0f1a500089e22c9
😎 Deploy Preview https://deploy-preview-387--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 70.00% and project coverage change: -0.11 ⚠️

Comparison is base (cb6ab45) 82.58% compared to head (3074a98) 82.47%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   82.58%   82.47%   -0.11%     
==========================================
  Files          31       31              
  Lines        3124     3122       -2     
==========================================
- Hits         2580     2575       -5     
- Misses        448      450       +2     
- Partials       96       97       +1
Impacted Files Coverage Δ
internal/daemonset/daemonset.go 97.66% <70.00%> (-0.79%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qbarrand
softdep: use a template
ad0525d 
Make the code generating the softdep config slightly more readable.
Generate the softdep config if at least two modules need ordered
loading.
@qbarrand qbarrand marked this pull request as ready for review May 2, 2023 10:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2023
@qbarrand
Copy link
Contributor Author

qbarrand commented May 2, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2023
@qbarrand qbarrand mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevgeny-shnaidman yevgeny-shnaidman Awaiting requested review from yevgeny-shnaidman

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qbarrand @k8s-ci-robot @codecov-commenter