Skip to content

Streamline GitHub Actions #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2022
Merged

Streamline GitHub Actions #39

merged 1 commit into from
Sep 8, 2022

Conversation

qbarrand
Copy link
Contributor

@qbarrand qbarrand commented Sep 6, 2022

Move the build of the manager binary to the unit-tests Prow script.
Remove the linting of the code in favor of the lint Prow script.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2022
ybettan
ybettan reviewed Sep 6, 2022
View reviewed changes
ci/prow/lint Outdated
Comment on lines 10 to 11
echo "Changes detected; diff:"
git diff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to print diff as the -x of the script will do it for us.

@codecov-commenter
Copy link

Codecov Report

Base: 63.69% // Head: 72.90% // Increases project coverage by +9.20% 🎉

Coverage data is based on head (5603905) compared to base (071840d).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   63.69%   72.90%   +9.20%     
==========================================
  Files          25       16       -9     
  Lines        1840     1587     -253     
==========================================
- Hits         1172     1157      -15     
+ Misses        609      371     -238     
  Partials       59       59
Impacted Files Coverage Δ
internal/registry/mock_registry_api.go
internal/build/mock_manager.go
internal/daemonset/mock_daemonset.go
internal/module/mock_kernelmapper.go
internal/auth/mock_auth.go
internal/preflight/mock_preflight_api.go
internal/statusupdater/mock_statusupdater.go
internal/build/mock_helper.go
internal/build/job/mock_maker.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ybettan
ybettan reviewed Sep 6, 2022
View reviewed changes
@qbarrand
Copy link
Contributor Author

qbarrand commented Sep 6, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@qbarrand qbarrand force-pushed the reduce-gha branch 4 times, most recently from 5380f69 to cc9a183 Compare September 7, 2022 08:19
@qbarrand
Copy link
Contributor Author

qbarrand commented Sep 7, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@qbarrand
Streamline GitHub Actions.
01db58e 
Move the build of the manager binary to the unit-tests Prow script.
Remove the linting of the code in favor of the lint Prow script.
@ybettan
Copy link
Contributor

ybettan commented Sep 7, 2022

Powerless LGTM.

@qbarrand
Copy link
Contributor Author

qbarrand commented Sep 7, 2022

/assign @yevgeny-shnaidman
This PR needs a /lgtm. Thanks!

@yevgeny-shnaidman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 629f3ba into kubernetes-sigs:main Sep 8, 2022
qbarrand referenced this pull request in qbarrand/kernel-module-management Sep 19, 2022
@qbarrand
Remove the DaemonSet reconciler (#39)
3b03e37 
Run the DaemonSet garbage collection in the Module reconciliation loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybettan ybettan ybettan left review comments

@yevgeny-shnaidman yevgeny-shnaidman Awaiting requested review from yevgeny-shnaidman

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@yevgeny-shnaidman yevgeny-shnaidman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qbarrand @k8s-ci-robot @codecov-commenter @ybettan @yevgeny-shnaidman