Explicitly checking PodPending when reporting Build/Sign status #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/XS
|
/assign @qbarrand |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
==========================================
+ Coverage 79.65% 79.69% +0.04%
==========================================
Files 43 43
Lines 4320 4320
==========================================
+ Hits 3441 3443 +2
+ Misses 721 719 -2
Partials 158 158
☔ View full report in Codecov by Sentry. |
|
/test pull-kernel-module-management-unit-tests |
qbarrand
reviewed
Sep 5, 2023
yevgeny-shnaidman
force-pushed
the
yevgeny/pod-pedning-phase
branch
from
0fb10ab to
281a421
Compare
k8s-ci-robot
added
size/S
|
/test pull-kernel-module-management-unit-tests |
yevgeny-shnaidman
force-pushed
the
yevgeny/pod-pedning-phase
branch
from
281a421 to
bdb2da6
Compare
|
/test pull-kernel-module-management-unit-tests |
Currently, PodPending phase of a running pod is not explicitly checked, which may cause an unnecessary errors reported. It does not affect the correctness of the flow, but does causes confusion in logs
yevgeny-shnaidman
force-pushed
the
yevgeny/pod-pedning-phase
branch
from
bdb2da6 to
ade98f9
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PodPending phase of a running pod is not explicitly checked, which may cause an unnecessary errors reported. It does not affect the correctness of the flow, but does causes confusion in logs