Skip to content

Update plantuml.jar download version and link #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2023
Merged

Update plantuml.jar download version and link #555

merged 1 commit into from
Sep 7, 2023

Conversation

enriquebelarte
Copy link
Contributor

@enriquebelarte enriquebelarte commented Sep 7, 2023 •
edited by qbarrand
Loading

Download from GitHub as Sourceforge seems to suffer from lower reliability.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2023
@netlify
Copy link

netlify bot commented Sep 7, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit cf7ac39
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/64f9b6239897d40008f6fdde
😎 Deploy Preview https://deploy-preview-555--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @enriquebelarte. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 7, 2023
@qbarrand
Copy link
Contributor

qbarrand commented Sep 7, 2023

/ok-to-test
/lgtm
/assign @yevgeny-shnaidman

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@enriquebelarte
Copy link
Contributor Author

/cc @qbarrand

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (08dabd7) 79.69% compared to head (cf7ac39) 79.69%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   79.69%   79.69%           
=======================================
  Files          43       43           
  Lines        4363     4363           
=======================================
  Hits         3477     3477           
  Misses        725      725           
  Partials      161      161

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yevgeny-shnaidman
Copy link
Contributor

/lgtm

@qbarrand
Copy link
Contributor

qbarrand commented Sep 7, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enriquebelarte, qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7eacee6 into kubernetes-sigs:main Sep 7, 2023
qbarrand added a commit to qbarrand/kernel-module-management that referenced this pull request Nov 8, 2023
@github-actions @qbarrand
Upgrade to controller-gen 0.12.0 (kubernetes-sigs#393) (kubernetes-si…
9de2b12 
…gs#555)

Upstream-Commit: 9fe42dc

Co-authored-by: Quentin Barrand <[email protected]>
qbarrand pushed a commit to qbarrand/kernel-module-management that referenced this pull request Nov 8, 2023
@github-actions @enriquebelarte
Update plantuml.jar download version and link (kubernetes-sigs#555) (k…
9234813 
…ubernetes-sigs#767)

Upstream-Commit: 7eacee6

Co-authored-by: Enrique Belarte Luque <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mresvanis mresvanis Awaiting requested review from mresvanis

@ybettan ybettan Awaiting requested review from ybettan

@qbarrand qbarrand Awaiting requested review from qbarrand

Assignees

@qbarrand qbarrand

@yevgeny-shnaidman yevgeny-shnaidman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enriquebelarte @k8s-ci-robot @qbarrand @codecov-commenter @yevgeny-shnaidman