Making GetModuleReady/GetDevicePluginReadyLabels functions public #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
approved
yevgeny-shnaidman
force-pushed
the
yevgeny/labels-public
branch
from
6ef16cb to
8430898
Compare
k8s-ci-robot
added
needs-rebase
since "ready" labels are public APIs of KMM, operators using KMM may want to schedule they workloads based on the presence of those labels.
yevgeny-shnaidman
force-pushed
the
yevgeny/labels-public
branch
from
8430898 to
c86574a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 79.07% 79.09% +0.01%
==========================================
Files 49 50 +1
Lines 5080 5084 +4
==========================================
+ Hits 4017 4021 +4
Misses 879 879
Partials 184 184 ☔ View full report in Codecov by Sentry. |
qbarrand
reviewed
Dec 20, 2023
|
/lgtm |
k8s-ci-robot
added
the
lgtm
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Jan 8, 2024
…bernetes-sigs#672) (kubernetes-sigs#937) since "ready" labels are public APIs of KMM, operators using KMM may want to schedule they workloads based on the presence of those labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since "ready" labels are public APIs of KMM, operators using KMM may want to schedule they workloads based on the presence of those labels.