Skip to content

Revert "Adding an operator-upgrade Github workflow." #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ybettan
Copy link
Contributor

@ybettan ybettan commented Jan 25, 2024

Reverts #693

There are a few issues with this commit:

  1. The test is flaky, at first I though it is related to the timeout
    duration that was increased in the PR but looks like it is not the
    root cause of the issue.
  2. Tide is enforcing this job although it was meant to be optional until it stabilize
  3. We should also modify the support-bundle to collect new pods logs as part of this change.

/cc @qbarrand

@k8s-ci-robot k8s-ci-robot requested a review from qbarrand January 25, 2024 09:48
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2024
Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit 83760eb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/65b22e775f5bd70008bb17ff
😎 Deploy Preview https://deploy-preview-715--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 25, 2024
@qbarrand
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e170ad0) 79.09% compared to head (83760eb) 79.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #715   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files          51       51           
  Lines        5109     5109           
=======================================
  Hits         4041     4041           
  Misses        882      882           
  Partials      186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot merged commit 5fc673e into kubernetes-sigs:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants