Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an operator-upgrade Github workflow. #716

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

ybettan
Copy link
Contributor

@ybettan ybettan commented Jan 25, 2024

This test will ensure the bundle built in the PR can be used to upgrade from the last bundle available of KMM.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ybettan ybettan changed the title Adding an operator-upgrade Github workflow. [WIP] Adding an operator-upgrade Github workflow. Jan 25, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 25, 2024
@ybettan
Copy link
Contributor Author

ybettan commented Jan 25, 2024

/uncc @mresvanis @yevgeny-shnaidman

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit b827485
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/65b8c4ce44b9c200080efeb4
😎 Deploy Preview https://deploy-preview-716--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fc673e) 79.09% compared to head (e493d3c) 79.09%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #716   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files          51       51           
  Lines        5109     5109           
=======================================
  Hits         4041     4041           
  Misses        882      882           
  Partials      186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybettan ybettan force-pushed the operator-upgrade branch 2 times, most recently from dd7d1ba to 4e8b8d7 Compare January 28, 2024 12:49
@ybettan ybettan changed the title [WIP] Adding an operator-upgrade Github workflow. Adding an operator-upgrade Github workflow. Jan 28, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2024
@ybettan ybettan changed the title Adding an operator-upgrade Github workflow. [WIP] Adding an operator-upgrade Github workflow. Jan 28, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2024
@ybettan ybettan force-pushed the operator-upgrade branch 9 times, most recently from 6131e4a to 8040a96 Compare January 29, 2024 15:56
@ybettan
Copy link
Contributor Author

ybettan commented Jan 29, 2024

/cc @qbarrand
It has passed 5/5 of the tries I did.

I have kept the explicit namespaces collection since although the default behavior documented is to collect data from all namespace I still got partial data and some of the objects were empty.

@k8s-ci-robot k8s-ci-robot requested a review from qbarrand January 29, 2024 16:03
@ybettan ybettan changed the title [WIP] Adding an operator-upgrade Github workflow. Adding an operator-upgrade Github workflow. Jan 29, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2024
This test will ensure the bundle built in the PR can be used to upgrade
from the last bundle available of KMM.

Signed-off-by: Yoni Bettan <[email protected]>
@qbarrand
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit a39a9ab into kubernetes-sigs:main Jan 30, 2024
@ybettan ybettan deleted the operator-upgrade branch January 30, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants