Skip to content

Allow the Hub to patch pods #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

qbarrand
Copy link
Contributor

This is required for the BuildSignEvents reconciler to remove the finalizer.

/cc @mresvanis @yevgeny-shnaidman

This is required for the BuildSignEvents reconciler to remove the
finalizer.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2024
Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit 8b1e725
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/65ba12dd7bcc6f000865859d
😎 Deploy Preview https://deploy-preview-720--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2024
@yevgeny-shnaidman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.09%. Comparing base (32fdc1a) to head (8b1e725).
Report is 126 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #720   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files          51       51           
  Lines        5109     5109           
=======================================
  Hits         4041     4041           
  Misses        882      882           
  Partials      186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot merged commit fa23a9b into kubernetes-sigs:main Jan 31, 2024
@qbarrand
Copy link
Contributor Author

/cherry-pick release-2.0

@qbarrand qbarrand deleted the hub-pod-patch branch January 31, 2024 11:22
@k8s-infra-cherrypick-robot

@qbarrand: new pull request created: #721

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants