-
Notifications
You must be signed in to change notification settings - Fork 34
Document symlinks for in-tree dependencies #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qbarrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
+ Coverage 79.09% 79.15% +0.06%
==========================================
Files 51 51
Lines 5109 3944 -1165
==========================================
- Hits 4041 3122 -919
+ Misses 882 636 -246
Partials 186 186 ☔ View full report in Codecov by Sentry. |
@qbarrand, this looks good to me. Thanks! |
/lgtm |
Fixes #517
@hershpa could you please have a look at this and let me know if this is clear enough? Thanks!
/cc @mresvanis