Skip to content

Document symlinks for in-tree dependencies #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

qbarrand
Copy link
Contributor

@qbarrand qbarrand commented Feb 5, 2024

Fixes #517

@hershpa could you please have a look at this and let me know if this is clear enough? Thanks!

/cc @mresvanis

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit b18a3fe
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/65c0feecd6da630008e03901
😎 Deploy Preview https://deploy-preview-726--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa23a9b) 79.09% compared to head (b18a3fe) 79.15%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
+ Coverage   79.09%   79.15%   +0.06%     
==========================================
  Files          51       51              
  Lines        5109     3944    -1165     
==========================================
- Hits         4041     3122     -919     
+ Misses        882      636     -246     
  Partials      186      186              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hershpa
Copy link
Contributor

hershpa commented Feb 5, 2024

Fixes #517

@hershpa could you please have a look at this and let me know if this is clear enough? Thanks!

/cc @mresvanis

@qbarrand, this looks good to me. Thanks!

@mresvanis
Copy link
Contributor

@qbarrand do we perhaps need to adjust the lab manifests as well?

@mresvanis
Copy link
Contributor

@qbarrand do we perhaps need to adjust the lab manifests as well?

We don't have to update the lab, as there is no kmod depending in an in-tree one 👍

@mresvanis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 80ebfac into kubernetes-sigs:main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: add an example of Dockerfile that utilizes link for dependencies on in-tree kmod
5 participants