Skip to content

OLM: do no use cert-manager #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

qbarrand
Copy link
Contributor

OLM provisions its own webhook certificates.
Do not include cert-manager as a dependency when deploying with OLM. Rework the directory layout to use cert-manager only when using make deploy.
Revert d4f87b0.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 26, 2024
@qbarrand
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2024
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit 547c5eb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/6602da28e68d750008701011
😎 Deploy Preview https://deploy-preview-770--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (fa23a9b) to head (b9a1a1d).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   79.09%   78.38%   -0.72%     
==========================================
  Files          51       54       +3     
  Lines        5109     4043    -1066     
==========================================
- Hits         4041     3169     -872     
+ Misses        882      679     -203     
- Partials      186      195       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

OLM provisions its own webhook certificates.
Do not include cert-manager as a dependency when deploying with OLM.
Rework the directory layout to use cert-manager only when using `make
deploy`.
Revert d4f87b0.
@qbarrand
Copy link
Contributor Author

/test all

@qbarrand qbarrand marked this pull request as ready for review March 26, 2024 14:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ybettan March 26, 2024 14:32
@yevgeny-shnaidman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit b83c8e3 into kubernetes-sigs:main Mar 26, 2024
22 checks passed
@qbarrand qbarrand deleted the olm-no-cert branch March 26, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants