Skip to content

Conditions: CRDs should not require patchStrategy and patchMergeKey on conditions #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoelSpeed opened this issue Jan 31, 2025 · 0 comments · Fixed by #37
Closed

Conditions: CRDs should not require patchStrategy and patchMergeKey on conditions #35

JoelSpeed opened this issue Jan 31, 2025 · 0 comments · Fixed by #37
Assignees
@JoelSpeed
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@JoelSpeed
Copy link
Contributor

Per conversation in slack these are not supported on CRDs, and so, like the protobuf markers, we should exclude them when running KAL against CRDs.

We should likely have a check that allows checking they are not present, to ensure CRD authors don't add them to their CRDs 🤔
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoelSpeed JoelSpeed

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PatchStrategy is not required on CRD conditions kubernetes-sigs/kube-api-linter
1 participant
@JoelSpeed