PatchStrategy is not required on CRD conditions #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
force-pushed
the
fix-crd-conditions-no-patch
branch
from
a6a6330 to
67fe26e
Compare
| missingMarkers = append(missingMarkers, patchMergeKeyType) | ||
| } | ||
| case config.ConditionsUsePatchStrategyIgnore: | ||
| // If it's there, we don't care. |
|
/lgtm I think this all seems reasonable, the tests pass so LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
CRDs are not compatible with
patchStrategy.This update adds a way to disable checking for the
patchStrategy, and aForbidoption for protobuf and the patchStrategy tags that means we can now suggest to remove the proto and patch strategy if they are present on our API types.