fix: ignore fields of json:"-"

[tsuzu]

https://pkg.go.dev/encoding/json#Marshal

• Ignore json:"-" fields in extractjsontags helper and commentstart analyzer

// Field is ignored by this package.
Field int `json:"-"`

• Don't ignore json:"-,"

// Field appears in JSON as key "-".
Field int `json:"-,"`

[JoelSpeed]

Please can you add a test case for the "-," case so that we make sure that's still working?

[tsuzu]

Please can you add a test case for the "-," case so that we make sure that's still working?

Sure, added!

[tsuzu]

pkg/analysis/helpers/extractjsontags/analyzer.go:84:1: calculated cyclomatic complexity for function extractTagInfo is 12, max is 10 (cyclop)
func extractTagInfo(tag *ast.BasicLit) FieldTagInfo {

I've got a linter error for extractTagInfo. Can I add nolint for this func? I don't have a good idea to split this func.

[JoelSpeed]

Something appears to have gone wrong with the linting here 🤔 Do you have time to investigate? I'm on PTO today

[tsuzu]

Enjoy your time off!

The error seems to be due to Go 1.24.0 release. And the support of Go 1.24.x for golangci-lint is still WIP: golangci/golangci-lint#5225
I've pinned golangci-lint job to Go 1.23, as well as the build job.

[ldez]

the support of Go 1.24.x for golangci-lint is still WIP

The support of Go 1.24 is not WIP since v1.64.0, I just left the issue open to catch feedback.
There is a message in bold inside the issue description about the availability of the support of go1.24, but this seems unclear, so I just closed the issue now.

[tsuzu]

Ahh, sorry! I missed it. Thank you so much for information.