Add template files #1
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
|
@caesarxuchao: changing LGTM is restricted to assignees, and only kubernetes-sigs/kube-storage-version-migrator repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks, nikhita! |
| @@ -3,4 +3,4 @@ | |||
| approvers: | |||
| - deads2k | |||
| - lavalamp | |||
| - xuchao | |||
| - caesarxuchao | |||
There was a problem hiding this comment.
I guess this is why I can't lgtm .
There was a problem hiding this comment.
I guess this is why I can't lgtm .
@caesarxuchao Even after this change, it won't work because you'll need to be a member of kubernetes-sigs for lgtm-ing. 🙃
You can send a request for kubernetes-sigs membership here.
There was a problem hiding this comment.
Thanks. Filed kubernetes/org#78.
nikhita
force-pushed
the
template-files
branch
from
6c0e8fc to
a56f59d
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
glad to see this moving forward |
|
@deads2k can you /approve this? |
|
/lgtm |
|
that's weird. why is /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
That's how it's defined in Prow. lgtm != implicit approve for kubernetes-sigs. |
|
/test all |
|
/retest |
enable build machinery
Ref kubernetes/steering#28 (comment), kubernetes/community#1832
The content is as per https://github.com/kubernetes/kubernetes-template-project.
/assign @deads2k @lavalamp
cc @caesarxuchao (looks like you need to send a request for kubernetes-sigs membership :))