-
Notifications
You must be signed in to change notification settings - Fork 83
Bump controller-runtime to v0.15.2 #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump controller-runtime to v0.15.2 #349
Conversation
HI @rayandas, Thank you for looking on that. It is not passing in the tests. By looking them: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kubebuilder-declarative-pattern/349/pull-declarative-test/1696632514203881472 I believe that if you just remove the indirect deps : https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kubebuilder-declarative-pattern/349/pull-declarative-test/1696632514203881472 and re-run go mod tidy it might be sorted out. |
e078052
to
a68ee27
Compare
a68ee27
to
0c9ace0
Compare
0c9ace0
to
9ac7f9f
Compare
9ac7f9f
to
f96d92a
Compare
This PR bumps controller-runtime from 0.15.0 to 0.15.2 . I updated the title to reflect that, and now that it is passing tests... /approve Thanks @rayandas |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rayandas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation: