-
Notifications
You must be signed in to change notification settings - Fork 1.6k
📖 Update generating crd link in docs #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update generating crd link in docs #2277
Conversation
Welcome @pravarag! |
Hi @pravarag. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -4,6 +4,6 @@ These markers describe how to construct a custom resource definition from | |||
a series of Go types and packages. Generation of the actual validation | |||
schema is described by the [validation markers](./crd-validation.md). | |||
|
|||
See [Generating CRDs](/reference/generating-crd.md) for examples. | |||
See [Generating CRDs](/docs/book/src/reference/generating-crd.md) for examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this prefix being used elsewhere in docs. I'd say just use relative pathing
See [Generating CRDs](/docs/book/src/reference/generating-crd.md) for examples. | |
See [Generating CRDs](../generating-crd.md) for examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @estroz , I'll update as suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 🙂
036ba16
to
a92c6fa
Compare
/ok-to-test |
/approve Thanks @pravarag |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz, pravarag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pravarag: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes: #2276
The Generating CRDs link is broken, a small correction to fix it.