📖 Fix link for component-config-tutorial #2279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rikatz
changed the title
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| @@ -3,7 +3,7 @@ | |||
| This tutorial will show you how to create a custom configuration file for your | |||
| project by modifying a project generated with the `--component-config` flag | |||
| passed to the `init` command. The full tutorial's source can be found | |||
| [here][tutorial-source]. Make sure you've gone through the [installation | |||
| [here](https://github.com/kubernetes-sigs/kubebuilder/tree/master/docs/book/src/component-config-tutorial/testdata/project). Make sure you've gone through the [installation | |||
There was a problem hiding this comment.
The link needs to be at the bottom,
We need still to use the alias.
Could you please fix it?
Co-authored-by: Camila Macedo <[email protected]>
|
flake? |
|
/test pull-kubebuilder-e2e-k8s-1-21-2 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approved |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
component-config-tutorial link on the book is broken :)
It's pointing to componentconfig-tutorial, missing the dash (-).
Also, some links / references are broken, I'm force pointing here to the correct location in GH repo but can investigate further how should this be done