Skip to content

📖 Fix grammar in lets -> let's. #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/book/src/cronjob-tutorial/testdata/finalizer_example.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func (r *CronJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
// examine DeletionTimestamp to determine if object is under deletion
if cronJob.ObjectMeta.DeletionTimestamp.IsZero() {
// The object is not being deleted, so if it does not have our finalizer,
// then lets add the finalizer and update the object. This is equivalent
// then let's add the finalizer and update the object. This is equivalent
// to registering our finalizer.
if !controllerutil.ContainsFinalizer(cronJob, myFinalizerName) {
controllerutil.AddFinalizer(cronJob, myFinalizerName)
Expand All @@ -75,7 +75,7 @@ func (r *CronJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
} else {
// The object is being deleted
if controllerutil.ContainsFinalizer(cronJob, myFinalizerName) {
// our finalizer is present, so lets handle any external dependency
// our finalizer is present, so let's handle any external dependency
if err := r.deleteExternalResources(cronJob); err != nil {
// if fail to delete the external dependency here, return with error
// so that it can be retried.
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func (v *Version) Parse(version string) error {

var err error
if v.Number, err = strconv.Atoi(substrings[0]); err != nil {
// Lets check if the `-` belonged to a negative number
// Let's check if the `-` belonged to a negative number
if n, err := strconv.Atoi(version); err == nil && n < 0 {
return errNonPositive
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/plugin/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func (v *Version) Parse(version string) error {

var err error
if v.Number, err = strconv.Atoi(substrings[0]); err != nil {
// Lets check if the `-` belonged to a negative number
// Let's check if the `-` belonged to a negative number
if n, err := strconv.Atoi(version); err == nil && n < 0 {
return errNegative
}
Expand Down