Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 (ci): improve PR title validation for a better security #4583

Merged

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Feb 28, 2025

  • Remove dependency on external scripts ()
  • Eliminate use of environment variables to prevent exposure risks
  • Perform inline PR title sanitization and validation

See that it still doing the same job: https://github.com/kubernetes-sigs/kubebuilder/actions/runs/13584176986/job/37975494509?pr=4583

This makes PR title verification fully self-contained, more efficient, and more secure.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2025
@camilamacedo86
Copy link
Member Author

@varshaprasad96 ^

@camilamacedo86
Copy link
Member Author

Moving forward with it

- Remove dependency on external scripts ()
- Eliminate use of environment variables to prevent exposure risks
- Perform inline PR title sanitization and validation

This makes PR title verification fully self-contained, more efficient, and more secure.
@camilamacedo86 camilamacedo86 changed the title 🌱 (ci): improve PR title validation for a better security (ci): improve PR title validation for a better security Feb 28, 2025
@camilamacedo86 camilamacedo86 changed the title (ci): improve PR title validation for a better security 🌱 (ci): improve PR title validation for a better security Feb 28, 2025
@camilamacedo86 camilamacedo86 merged commit 8c817f5 into kubernetes-sigs:master Feb 28, 2025
18 of 25 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-ci-title-check branch February 28, 2025 08:25
@camilamacedo86 camilamacedo86 restored the fix-ci-title-check branch February 28, 2025 08:28
@camilamacedo86 camilamacedo86 deleted the fix-ci-title-check branch February 28, 2025 08:28
akagami-harsh pushed a commit to akagami-harsh/kubebuilder that referenced this pull request Mar 3, 2025
…-sigs#4583)

(ci): improve PR title validation for a better security

- Remove dependency on external scripts ()
- Eliminate use of environment variables to prevent exposure risks
- Perform inline PR title sanitization and validation

This makes PR title verification fully self-contained, more efficient, and more secure.
dongjiang1989 pushed a commit to dongjiang1989/kubebuilder that referenced this pull request Apr 1, 2025
…-sigs#4583)

(ci): improve PR title validation for a better security

- Remove dependency on external scripts ()
- Eliminate use of environment variables to prevent exposure risks
- Perform inline PR title sanitization and validation

This makes PR title verification fully self-contained, more efficient, and more secure.
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this pull request Apr 1, 2025
…-sigs#4583)

(ci): improve PR title validation for a better security

- Remove dependency on external scripts ()
- Eliminate use of environment variables to prevent exposure risks
- Perform inline PR title sanitization and validation

This makes PR title verification fully self-contained, more efficient, and more secure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants