✨ (CLI, go/v4): Upgrade Golang version to v1.24.0 #4585

dongjiang1989 · 2025-02-28T12:48:11Z

Upgrade go version 1.23 to 1.24

k8s-ci-robot · 2025-02-28T12:48:20Z

Welcome @dongjiang1989!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-02-28T12:48:21Z

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

camilamacedo86 · 2025-02-28T13:11:47Z

/ok-to-test

.golangci.yml

.github/workflows/lint.yml

dongjiang1989 · 2025-02-28T13:24:57Z

@camilamacedo86 How to change golang version here?
ref: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kubebuilder/4585/pull-kubebuilder-test/1895464276731105280

Maybe change prow image image: public.ecr.aws/docker/library/golang:1.23 to image: public.ecr.aws/docker/library/golang:1.24

camilamacedo86 · 2025-02-28T13:53:38Z

Hi @dongjiang1989

Maybe change prow image image: public.ecr.aws/docker/library/golang:1.23 to image: public.ecr.aws/docker/library/golang:1.24

We will need to update the the test-infra: http://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml#L14

Feel free to push a PR and ping me.
I will be happy to approve 👍

dongjiang1989 · 2025-02-28T14:48:01Z

cc @camilamacedo86 kubernetes/test-infra#34430 PTAL

camilamacedo86 · 2025-03-03T08:57:07Z

Hi @dongjiang1989

I saw that you open the PR there as well.
Let's wait just a little ideally, we should only bump the Golang when it is bumped in the k8s API and controller-runtime and we bump here. But lets give a couple of weeks, then I think we can go.

camilamacedo86 · 2025-03-04T10:14:48Z

Just for we keep tracked here:

Update Golang version to 1.24 for kubebuilder unit test image kubernetes/test-infra#34430

camilamacedo86 · 2025-03-11T16:17:23Z

@dongjiang1989

Let's bump controller-runtime latest release which still uses 1.23 : https://github.com/kubernetes-sigs/controller-runtime/blob/v0.20.3/go.mod

Do a patch release, and then I think we might can move forward with this one.

dongjiang1989 · 2025-03-12T10:58:45Z

@dongjiang1989

Let's bump controller-runtime latest release which still uses 1.23 : https://github.com/kubernetes-sigs/controller-runtime/blob/v0.20.3/go.mod

Do a patch release, and then I think we might can move forward with this one.

Thanks @camilamacedo86
Got it.
controller-runtime master branch update golang version to v1.24:
kubernetes-sigs/controller-runtime@9d65299

Patch it to controller-runtime v0.20.x?

camilamacedo86 · 2025-03-26T21:15:30Z

/lgtm
/approved
/ok-to-test

camilamacedo86 · 2025-03-27T17:57:13Z

Hi @dongjiang1989

we need to upgrade the golang-ci to allow it pass

mateusoliveira43 · 2025-03-27T18:54:17Z

@camilamacedo86 checking errors, maybe we do not need to update linter for this one to pass. I think error is related to how it is being installed. If we use go install both in root Makefile

kubebuilder/Makefile

Line 128 in 2b35f33

    
           curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell dirname $(GOLANGCI_LINT)) v1.63.4 ;\

like is done for testdata

kubebuilder/testdata/project-v4/Makefile

Line 221 in 2b35f33

GOBIN=$(LOCALBIN) go install $${package} ;\

and in github actions

kubebuilder/.github/workflows/lint.yml

Line 29 in 2b35f33

version: v1.63.4

https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#install-mode

I think CI will work for this one (without changing linter version)

camilamacedo86

Can you please help us ensure that it pass in the CI and also squash the commits to allow us to move forward?

Signed-off-by: dongjiang <[email protected]> fix golangci lint Signed-off-by: dongjiang <[email protected]> revent golangcl-lint Signed-off-by: dongjiang <[email protected]> add go install mode Signed-off-by: dongjiang <[email protected]>

dongjiang1989 · 2025-04-01T01:57:28Z

Hi @dongjiang1989,

Thank you so much for this one! 👍 Everything looks great — we're just missing one last step: squashing the commits.

We follow a policy of having one commit per PR for each need/requirement/change. This helps us maintain a clean Git history and makes things easier when we need to revert or track changes.

Could you please squash the commits so we can get this one merged? 🙏

Thanks again!

Done :)

camilamacedo86 · 2025-04-01T22:19:15Z

.github/workflows/lint-sample.yml

@@ -38,6 +38,7 @@ jobs:
      - name: Run linter
        uses: golangci/golangci-lint-action@v6
        with:
+          install-mode: goinstall


I understand that allowing us to pass the CI and ensure that the lint works was required.
Am I right? Would it work without this change?

This change solved the issue

Error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.0)
Failed executing command with error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.0)

Right?

Yes. Solved it done.

Lets move forward but I create an issue to see if we can remove it before the next release or if we should leave it as it is now: #4750

This was not the right fix.

You are using golangci-lint v1.63, the first version of golangci-lint that supports go1.24 is golangci-lint v1.64.

The right fix is to update the golangci-lint version to a version that support go1.24

Thanks @ldez
Got it

dongjiang1989 · 2025-04-02T12:47:03Z

Thanks @camilamacedo86 Please re-check it :)

camilamacedo86

/lgtm
/approve
/ok-to-test

k8s-ci-robot · 2025-04-02T21:55:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, dongjiang1989

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2025

k8s-ci-robot requested review from camilamacedo86 and rashmigottipati February 28, 2025 12:48

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2025

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 28, 2025

camilamacedo86 reviewed Feb 28, 2025

View reviewed changes

.golangci.yml Outdated Show resolved Hide resolved

camilamacedo86 reviewed Feb 28, 2025

View reviewed changes

.github/workflows/lint.yml Outdated Show resolved Hide resolved

dongjiang1989 mentioned this pull request Feb 28, 2025

Update Golang version to 1.24 for kubebuilder unit test image kubernetes/test-infra#34430

Merged

k8s-ci-robot closed this in kubernetes/test-infra#34430 Mar 26, 2025

camilamacedo86 reopened this Mar 26, 2025

k8s-ci-robot assigned camilamacedo86 Mar 26, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025

camilamacedo86 approved these changes Mar 26, 2025

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025

camilamacedo86 requested changes Mar 28, 2025

View reviewed changes

dongjiang1989 force-pushed the update-go-1.24 branch 2 times, most recently from a927b6d to 49d5eac Compare April 1, 2025 01:52

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2025

dongjiang1989 force-pushed the update-go-1.24 branch from 49d5eac to f91e8fb Compare April 1, 2025 01:55

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2025

update golang version to v1.2.4.0

1ca4470

Signed-off-by: dongjiang <[email protected]> fix golangci lint Signed-off-by: dongjiang <[email protected]> revent golangcl-lint Signed-off-by: dongjiang <[email protected]> add go install mode Signed-off-by: dongjiang <[email protected]>

dongjiang1989 force-pushed the update-go-1.24 branch from f91e8fb to 1ca4470 Compare April 1, 2025 01:55

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 1, 2025

dongjiang1989 closed this Apr 1, 2025

dongjiang1989 reopened this Apr 1, 2025

camilamacedo86 reviewed Apr 1, 2025

View reviewed changes

camilamacedo86 closed this Apr 1, 2025

camilamacedo86 reopened this Apr 1, 2025

camilamacedo86 mentioned this pull request Apr 2, 2025

After upgrade golangci, check if we still needing to use install-mode: goinstall in the actions #4750

Closed

camilamacedo86 approved these changes Apr 2, 2025

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025

k8s-ci-robot merged commit b878bf9 into kubernetes-sigs:master Apr 2, 2025
58 of 61 checks passed

dongjiang1989 deleted the update-go-1.24 branch April 3, 2025 01:43

dongjiang1989 mentioned this pull request Apr 10, 2025

🌱 (Follow up of #4752 )Remove 'install-mode: goinstall' from the GitHub Action. This was added temporarily to allow us to move forward. (removed this temporary addition before any release.) #4774

Merged

This was referenced May 24, 2025

🐛 (go/v4) fix: revert accidental addition of explicit docker.io registry in Dockerfile #4818

Merged

New release 4.6.0 #4820

Closed

✨ (CLI, go/v4): Upgrade Golang version to v1.24.0 #4585

✨ (CLI, go/v4): Upgrade Golang version to v1.24.0 #4585

Uh oh!

Conversation

dongjiang1989 commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 28, 2025

Uh oh!

k8s-ci-robot commented Feb 28, 2025

Uh oh!

camilamacedo86 commented Feb 28, 2025

Uh oh!

Uh oh!

Uh oh!

dongjiang1989 commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camilamacedo86 commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dongjiang1989 commented Feb 28, 2025

Uh oh!

camilamacedo86 commented Mar 3, 2025

Uh oh!

camilamacedo86 commented Mar 4, 2025

Uh oh!

camilamacedo86 commented Mar 11, 2025

Uh oh!

dongjiang1989 commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camilamacedo86 commented Mar 26, 2025

Uh oh!

camilamacedo86 commented Mar 27, 2025

Uh oh!

mateusoliveira43 commented Mar 27, 2025

Uh oh!

camilamacedo86 left a comment

Choose a reason for hiding this comment

Uh oh!

dongjiang1989 commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camilamacedo86 Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dongjiang1989 Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

ldez Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

dongjiang1989 Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

dongjiang1989 commented Apr 2, 2025

Uh oh!

camilamacedo86 left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 2, 2025

Uh oh!

Uh oh!

Uh oh!

dongjiang1989 commented Feb 28, 2025 •

edited

Loading

dongjiang1989 commented Feb 28, 2025 •

edited

Loading

camilamacedo86 commented Feb 28, 2025 •

edited

Loading

dongjiang1989 commented Mar 12, 2025 •

edited

Loading

dongjiang1989 commented Apr 1, 2025 •

edited

Loading

camilamacedo86 Apr 1, 2025 •

edited

Loading