Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Upgrade controller-runtime from v0.20.2 to v0.20.3 #4604

Conversation

vitorfloriano
Copy link
Contributor

@vitorfloriano vitorfloriano commented Mar 12, 2025

✨ Upgrade controller-runtime from v0.20.2 to v0.20.3

Closes: #4602

Copy link

linux-foundation-easycla bot commented Mar 12, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vitorfloriano / name: Vitor Floriano (9cfeb37)

@k8s-ci-robot
Copy link
Contributor

Welcome @vitorfloriano!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vitorfloriano. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vitorfloriano vitorfloriano changed the title ✨ Upgrade controller-runtime from v0.20.2 to v0.20. ✨ Upgrade controller-runtime from v0.20.2 to v0.20.3 Mar 12, 2025
@knabben
Copy link
Member

knabben commented Mar 12, 2025

/reopen
/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@knabben: Reopened this PR.

In response to this:

/reopen
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot reopened this Mar 12, 2025
cmd/version.go Outdated
@@ -27,7 +27,7 @@ const unknown = "unknown"
// information in the release process
var (
kubeBuilderVersion = unknown
kubernetesVendorVersion = unknown
kubernetesVendorVersion = "1.32.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to change this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we do not need to change it because it should be set automatically can you please revert and ensure that we have only 1 commit here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 Just for reassurance, I ran make generate again and it updated the value for kubernetesVendorVersion from unknown back to "1.32.1".

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 12, 2025
@vitorfloriano vitorfloriano force-pushed the bump-controller-runtime-v0.20.3 branch from b338cc8 to f3080da Compare March 12, 2025 13:57
@vitorfloriano vitorfloriano force-pushed the bump-controller-runtime-v0.20.3 branch from f3080da to 9cfeb37 Compare March 12, 2025 14:00
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/aprove
/ok-to-test

Thank you 🥇

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 12, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, vitorfloriano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@knabben
Copy link
Member

knabben commented Mar 12, 2025

The APIDiff / Verify API differences (pull_request) failure is expected here, since we are bumping the library:

sigs.k8s.io/kubebuilder/v4/pkg/plugins/golang/v4/scaffolds
  Incompatible changes:
  - ControllerRuntimeVersion: value changed from "v0.20.2" to "v0.20.3"'

@knabben
Copy link
Member

knabben commented Mar 12, 2025

/lgtm

@camilamacedo86
Copy link
Member

In this case, we expected the APIDiff fail.
This check is not to allow us to break things so we can move forward, np at all.
Thank you a lot for the contribution 🎉

@camilamacedo86 camilamacedo86 merged commit 33675ce into kubernetes-sigs:master Mar 12, 2025
31 of 33 checks passed
@vitorfloriano vitorfloriano deleted the bump-controller-runtime-v0.20.3 branch March 12, 2025 16:21
camilamacedo86 pushed a commit to camilamacedo86/kubebuilder that referenced this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump controller runtime v0.20.3
4 participants