-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Upgrade controller-runtime from v0.20.2 to v0.20.3 #4604
✨ Upgrade controller-runtime from v0.20.2 to v0.20.3 #4604
Conversation
|
Welcome @vitorfloriano! |
Hi @vitorfloriano. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@knabben: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cmd/version.go
Outdated
@@ -27,7 +27,7 @@ const unknown = "unknown" | |||
// information in the release process | |||
var ( | |||
kubeBuilderVersion = unknown | |||
kubernetesVendorVersion = unknown | |||
kubernetesVendorVersion = "1.32.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we do not need to change it because it should be set automatically can you please revert and ensure that we have only 1 commit here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 Just for reassurance, I ran make generate
again and it updated the value for kubernetesVendorVersion
from unknown
back to "1.32.1"
.
b338cc8
to
f3080da
Compare
f3080da
to
9cfeb37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/aprove
/ok-to-test
Thank you 🥇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, vitorfloriano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The APIDiff / Verify API differences (pull_request) failure is expected here, since we are bumping the library:
|
/lgtm |
In this case, we expected the APIDiff fail. |
33675ce
into
kubernetes-sigs:master
…#4604) Upgrade controller-runtime from v0.20.2 to v0.20.3
✨ Upgrade controller-runtime from v0.20.2 to v0.20.3
Closes: #4602