-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Make the Kind integration in the Makefile configurable like the other variables. #4615
Conversation
Remove the hardcoded Kind version and related logic from Makefile templates. Introduce a variable for the Kind binary in e2e tests to allow using Kind installations located outside of $PATH.
Welcome @kersten! |
Hi @kersten. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/approved
/lgtm
Thank you for your contribution. 🎉
I hope you do not mind, I updated the title so we can move forward.
See that because this change impact the end users ( change the scaffold ) should be added in the release notes so because of this we cannot use the 🌱 emoji.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, kersten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR removes the hardcoded Kind version and related logic from the Makefile templates. Instead, it introduces a variable for the Kind binary in end-to-end (e2e) tests, allowing users to specify a Kind installation located outside of $PATH.
Motivation
Currently, the Makefile templates assume a fixed Kind version and location, which limits flexibility. This change ensures that Kind can be used from custom locations, improving compatibility in different environments.
Let me know if you want to tweak anything! 🚀