Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 (chore): clean up var declarations in grafana scaffolder and cronjob doc generator #4670

Merged
merged 2 commits into from
Mar 26, 2025
Merged

🌱 (chore): clean up var declarations in grafana scaffolder and cronjob doc generator #4670

merged 2 commits into from
Mar 26, 2025

Conversation

kersten
Copy link
Contributor

@kersten kersten commented Mar 26, 2025

Refactored var declarations to use short form where appropriate:

  • Replaced var templatesBuilder = with := in the Grafana scaffolder.
  • Replaced var fs = with := in the cronjob tutorial generator. This improves code clarity and aligns with idiomatic Go style.

@kersten
style: clean up var declarations in grafana scaffolder and cronjob do…
c682b96 
…c generator

Refactored `var` declarations to use short form where appropriate:
- Replaced `var templatesBuilder =` with `:=` in the Grafana scaffolder.
- Replaced `var fs =` with `:=` in the cronjob tutorial generator.
This improves code clarity and aligns with idiomatic Go style.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2025
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kersten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

camilamacedo86
camilamacedo86 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, kersten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025
@camilamacedo86 camilamacedo86 merged commit 3ae9604 into kubernetes-sigs:master Mar 26, 2025
20 of 22 checks passed
@kersten kersten deleted the style/short-var-decl-cleanup branch March 27, 2025 09:50
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this pull request Apr 1, 2025
@kersten @camilamacedo86
🌱 (chore): clean up var declarations in grafana scaffolder and cronjo…
5bf59b4 
…b doc generator (kubernetes-sigs#4670)

style: clean up var declarations in grafana scaffolder and cronjob doc generator

Refactored `var` declarations to use short form where appropriate:
- Replaced `var templatesBuilder =` with `:=` in the Grafana scaffolder.
- Replaced `var fs =` with `:=` in the cronjob tutorial generator.
This improves code clarity and aligns with idiomatic Go style.

Co-authored-by: Camila Macedo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kersten @k8s-ci-robot @camilamacedo86