Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 (chore): improve readability of test case for alternative delimiters #4671

Merged
merged 1 commit into from
Mar 26, 2025
Merged

🌱 (chore): improve readability of test case for alternative delimiters #4671

merged 1 commit into from
Mar 26, 2025

Conversation

kersten
Copy link
Contributor

@kersten kersten commented Mar 26, 2025

Reformatted the inline struct definition in scaffold_test.go to a multi-line layout.

@kersten
chore: improve readability of test case for alternative delimiters
8cf39c8 
Reformatted the inline struct definition in `scaffold_test.go` to a multi-line
layout.
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kersten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2025
camilamacedo86
camilamacedo86 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, kersten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
@camilamacedo86 camilamacedo86 merged commit 64ca4f4 into kubernetes-sigs:master Mar 26, 2025
21 of 22 checks passed
@kersten kersten deleted the chore/improve-delimiter-test-readability branch March 27, 2025 09:49
@kersten kersten restored the chore/improve-delimiter-test-readability branch March 27, 2025 21:36
@kersten kersten deleted the chore/improve-delimiter-test-readability branch April 1, 2025 10:07
camilamacedo86 pushed a commit to camilamacedo86/kubebuilder that referenced this pull request Apr 1, 2025
@kersten @camilamacedo86
🌱 (chore): improve readability of test case for alternative delimiters (
0aa3e30 
kubernetes-sigs#4671)

chore: improve readability of test case for alternative delimiters

Reformatted the inline struct definition in `scaffold_test.go` to a multi-line
layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kersten @k8s-ci-robot @camilamacedo86