Skip to content

🌱 (chore): replace empty slice literals with idiomatic var decls #4736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

🌱 (chore): replace empty slice literals with idiomatic var decls #4736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ook/src/getting-started/testdata/project/internal/controller/memcached_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ var _ = Describe("Memcached Controller", func() {

By("Checking the latest Status Condition added to the Memcached instance")
Expect(k8sClient.Get(ctx, typeNamespacedName, memcached)).To(Succeed())
conditions := []metav1.Condition{}
var conditions []metav1.Condition
Expect(memcached.Status.Conditions).To(ContainElement(
HaveField("Type", Equal(typeAvailableMemcached)), &conditions))
Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableMemcached)
Expand Down
2 changes: 1 addition & 1 deletion hack/docs/internal/getting-started/generate_getting_started.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func (sp *Sample) updateControllerTest() {

By("Checking the latest Status Condition added to the Memcached instance")
Expect(k8sClient.Get(ctx, typeNamespacedName, memcached)).To(Succeed())
conditions := []metav1.Condition{}
var conditions []metav1.Condition
Expect(memcached.Status.Conditions).To(ContainElement(
HaveField("Type", Equal(typeAvailableMemcached)), &conditions))
Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableMemcached)
Expand Down
4 changes: 2 additions & 2 deletions pkg/plugins/external/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ func bindSpecificFlags(fs *pflag.FlagSet, flags []external.Flag) {
}

func filterFlags(flags []external.Flag, externalFlagFilters []externalFlagFilterFunc) []external.Flag {
filteredFlags := []external.Flag{}
var filteredFlags []external.Flag
for _, flag := range flags {
ok := true
for _, filter := range externalFlagFilters {
Expand All @@ -271,7 +271,7 @@ func filterFlags(flags []external.Flag, externalFlagFilters []externalFlagFilter
}

func filterArgs(args []string, argFilters []argFilterFunc) []string {
filteredArgs := []string{}
var filteredArgs []string
for _, arg := range args {
ok := true
for _, filter := range argFilters {
Expand Down
2 changes: 1 addition & 1 deletion .../golang/deploy-image/v1alpha1/scaffolds/internal/templates/controllers/controller-test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ var _ = Describe("{{ .Resource.Kind }} controller", func() {

By("Checking the latest Status Condition added to the {{ .Resource.Kind }} instance")
Expect(k8sClient.Get(ctx, typeNamespacedName, {{ lower .Resource.Kind }})).To(Succeed())
conditions := []metav1.Condition{}
var conditions []metav1.Condition
Expect({{ lower .Resource.Kind }}.Status.Conditions).To(ContainElement(
HaveField("Type", Equal(typeAvailable{{ .Resource.Kind }})), &conditions))
Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailable{{ .Resource.Kind }})
Expand Down
2 changes: 1 addition & 1 deletion pkg/plugins/optional/grafana/v1alpha/scaffolds/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func configReader(reader io.Reader) ([]templates.CustomMetricItem, error) {

func validateCustomMetricItems(rawItems []templates.CustomMetricItem) []templates.CustomMetricItem {
// 1. Filter items of missing `Metric` or `Type`
filterResult := []templates.CustomMetricItem{}
var filterResult []templates.CustomMetricItem
for _, item := range rawItems {
if hasFields(item) {
filterResult = append(filterResult, item)
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v4-multigroup/internal/controller/example.com/busybox_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ var _ = Describe("Busybox controller", func() {

By("Checking the latest Status Condition added to the Busybox instance")
Expect(k8sClient.Get(ctx, typeNamespacedName, busybox)).To(Succeed())
conditions := []metav1.Condition{}
var conditions []metav1.Condition
Expect(busybox.Status.Conditions).To(ContainElement(
HaveField("Type", Equal(typeAvailableBusybox)), &conditions))
Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableBusybox)
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v4-multigroup/internal/controller/example.com/memcached_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ var _ = Describe("Memcached controller", func() {

By("Checking the latest Status Condition added to the Memcached instance")
Expect(k8sClient.Get(ctx, typeNamespacedName, memcached)).To(Succeed())
conditions := []metav1.Condition{}
var conditions []metav1.Condition
Expect(memcached.Status.Conditions).To(ContainElement(
HaveField("Type", Equal(typeAvailableMemcached)), &conditions))
Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableMemcached)
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v4-with-plugins/internal/controller/busybox_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ var _ = Describe("Busybox controller", func() {

By("Checking the latest Status Condition added to the Busybox instance")
Expect(k8sClient.Get(ctx, typeNamespacedName, busybox)).To(Succeed())
conditions := []metav1.Condition{}
var conditions []metav1.Condition
Expect(busybox.Status.Conditions).To(ContainElement(
HaveField("Type", Equal(typeAvailableBusybox)), &conditions))
Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableBusybox)
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v4-with-plugins/internal/controller/memcached_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ var _ = Describe("Memcached controller", func() {

By("Checking the latest Status Condition added to the Memcached instance")
Expect(k8sClient.Get(ctx, typeNamespacedName, memcached)).To(Succeed())
conditions := []metav1.Condition{}
var conditions []metav1.Condition
Expect(memcached.Status.Conditions).To(ContainElement(
HaveField("Type", Equal(typeAvailableMemcached)), &conditions))
Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableMemcached)
Expand Down