🌱 added backup files in gitignore #4758
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kuzuri247 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @Kuzuri247. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
| @@ -28,3 +28,6 @@ docs/book/src/docs | |||
| /testdata/**/go.sum | |||
| /docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1/bin | |||
| /testdata/**legacy** | |||
|
|
|||
| # skip backup files while migrating | |||
| .golangci.bck.yml | |||
There was a problem hiding this comment.
Why should we add it?
Is not this file added just once?
When was the migration made?
There was a problem hiding this comment.
I manually deleted the backup files in #4757
There was a problem hiding this comment.
That's what I imagined as well, but do we actually expect this file to be present in the future, or was it just needed for a one-time operation?
There was a problem hiding this comment.
The backup file is just the previous golangci.yml file which is upgraded and then golangci makes it as a backup
There was a problem hiding this comment.
So, I think we can agree that there's no need to add anything here, right?
Since this is a one-time operation, and after the migration we shouldn't see this file anymore.
Would you mind closing this one as deferred?
|
One time change |
Added golangci backup yml while migration