-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore: Use go tools #1648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: Use go tools #1648
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mrueg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Marek Siarkowicz <[email protected]>
/retest |
I guess bumping golangci-lint to a more recent version fixed it. |
@@ -30,7 +30,15 @@ ALL_BINARIES_PLATFORMS= $(addprefix linux/,$(ALL_ARCHITECTURES)) \ | |||
|
|||
# Tools versions | |||
# -------------- | |||
GOLANGCI_VERSION:=1.64.8 | |||
GOLANGCI_VERSION:=2.1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not upgrade golanci in the same PR. It makes review much more complicated. You don't need to migrate all the tools at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
If upgrading golangci-lint is mandatory, we can start a new PR and get back to this after that.
/triage accepted since you're already looking at it :) Thanks! |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This makes use of
go tools
to manage tooling for metrics-server.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #