-
Notifications
You must be signed in to change notification settings - Fork 797
Add securityContext options to Helm Chart - Related to Issue #97 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update Deployment with securityContext for pod and Container
Adding securityContext variables to the values file.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BYondRAK The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @BYondRAK! |
/retitle Add securityContext options to Helm Chart - Resolves #97 |
@BYondRAK: Re-titling can only be requested by trusted users, like repository collaborators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi,
when changing the helm chart, it is required to bump the helm chart version in the Chart.yaml
as well, unless, the PR will be un-mergable since the tests will fail because every change in the helm chart triggers automatic chart version release once merged to master
.
bump @BYondRAK :) |
bump @BYondRAK :) |
bump @BYondRAK :) |
bump @BYondRAK :) |
completed in #171 thanks to @danieljkemp |
@BYondRAK: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@yonatankahana: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Allow users to supply value overrides in the deployment to support podSecurtyContext and container securityContext.