-
Notifications
You must be signed in to change notification settings - Fork 177
Support structured logging: broadcaster & eventRecorder #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support structured logging: broadcaster & eventRecorder #171
Conversation
/wg structured-logging |
@bells17: GitHub didn't allow me to request PR reviews from the following users: kubernetes/wg-structured-logging-reviews. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bells17: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ac4d7ae
to
358f93a
Compare
358f93a
to
1b5aac4
Compare
Signature of |
@jsafrane, I'm thinking of using the following text for the release notes. Do you think this is appropriate?
|
That would work nicely. |
@jsafrane Thank you! I've updated the release note. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bells17, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
In the following PR, support for contextual logging was implemented, but the broadcaster and eventRecorder were not updated to support contextual logging.
#154
Therefore, I made changes to enable the use of contextual logging within the broadcaster and eventRecorder as well.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
kubernetes/kubernetes#120729
Does this PR introduce a user-facing change?: