fix docker build arguments #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cofyc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
cofyc
commented
Aug 15, 2019
| WORKDIR /go/src/sigs.k8s.io/sig-storage-local-static-provisioner | ||
| ADD . . | ||
| RUN echo "OS: $OS ARCH: $ARCH" |
There was a problem hiding this comment.
docker build does not show replaced variables. I add this to show current values.
FROM instruction starts a new build-stage, and any property from the previous stage (if any) is reset.
msau42
reviewed
Aug 15, 2019
| @@ -12,17 +12,21 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| ARG OS=linux | |||
| ARG ARCH=amd64 | |||
There was a problem hiding this comment.
Do we still need these 2 args?
There was a problem hiding this comment.
ARG OS=linux is not needed, so deleted. ARG ARCH=amd64 is required because it's used in FROM k8s.gcr.io/debian-base-${ARCH}:0.4.1 instruction.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
davidmccormick
pushed a commit
to davidmccormick/sig-storage-local-static-provisioner
that referenced
this pull request
Mar 31, 2021
fix docker build arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #95