-
Notifications
You must be signed in to change notification settings - Fork 24
cgroupv2 support #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cgroupv2 support #140
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Taking this out of draft so CI runs. I was able to get the basic cgroupv2 integration test (copied from the "basic" test) to mostly pass. There was a little bit of weirdness in the output values that I am not sure if I should just update the test case for or if there's an actual problem. I noticed min.slice on cgroupv1 had a -1 value in the input samples. This did not work with cgroupv2 so I changed those results to 0s, but the test data isn't quite as expected. I'm not sure if there is a special meaning to the -1 CPU usage on cgroupv1. Otherwise, this should not break any cgroupv1 functionality. I will work on ctrstats next but that should be more of a trivial change, so if folks want to take a look at this now, it should be ready for initial review. I will also edit my first comment with the dictionary for updating v1 to v2. |
/retest-required flake #126 |
/triage accepted |
/retest-required flake #126 |
/retest-required |
Closes #138.
Goals:
Design:
Details can be found at #138 (comment)
Summary of changes:
cpu.stat
filememory.current
(unlikememory.usage_in_bytes
on v1 which was an estimate)memory.events
anon
field out ofmemory.stat
file