Update owners files for autoscaling #1174
Conversation
k8s-ci-robot
added
cncf-cla: yes
cluster-autoscaler/OWNERS
Outdated
| @@ -1,9 +1,11 @@ | |||
| approvers: | |||
| - fgrzadkowski | |||
| - mwielgus | |||
There was a problem hiding this comment.
mwielgus is already a top level owner, so probably redundant here (or I want to be included as well :) )
|
Do we want to add an OWNERS file for builder/ as well? It's specific to Cluster Autoscaler and changes there are necessary e.g. when adding extra build dependency (that won't be included in the release image anyway). However, with the new setup it will require approval by top-level OWNERS. Given that changes such as adding dependencies to be included in the release image only require cluster-autoscaler/OWNERS approval, this doesn't seem right. |
|
@aleksandra-malinowska shouldn't the builder be used for all autoscaling images (I have some wip that adds build-in-docker to vpa)? Then this would imply that top-level OWNERS is right for it. |
|
If this is going to be the case, then sure, it should probably require top-level approval, to avoid one project's dependencies' update from breaking another one. Although I don't think it's the best idea to share it, given that each project may require different dependencies. In particular, sharing it would mean we'd always have to sync upgrading to use newer version of Go for all projects (which would in some cases mean synchronized godeps update for all of them.) |
|
addon-resizer/OWNERS already exists, but +1 to updating it (AFAIU Q-Lee is no longer working on this, and current maintainers are missing) |
|
Added addon-resizer changes. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
….Condition (kubernetes#1174) * [api/admissioncheck] Use custom AdmissionCheckState instead of metav1.Condition * Review Remarks * Review remarks.
fixes #1111