Skip to content

Commit 46bd935

Browse files
authored
Merge pull request #4876 from castrojo/guide-updates
Merge getting started into the main page as they're required.
2 parents ede2de3 + 67c6f7f commit 46bd935

File tree

5 files changed

+73
-87
lines changed

5 files changed

+73
-87
lines changed

contributors/guide/README.md

+44-8
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,63 @@
1+
# Welcome
2+
3+
Have you ever wanted to contribute to the coolest cloud technology?
4+
We will help you understand the organization of the Kubernetes project and direct you to the best places to get started.
5+
You'll be able to pick up issues, write code to fix them, and get your work reviewed and merged.
6+
17
This document is the single source of truth for how to contribute to the code base.
28
Feel free to browse the [open issues](https://github.com/kubernetes/community/issues?q=is%3Aissue+is%3Aopen+label%3Aarea%2Fcontributor-guide) and file new ones, all feedback welcome!
39

4-
# Welcome
10+
## Contributor Guide
11+
12+
Welcome to Kubernetes! This guide is broken up into the following sections.
13+
It is recommended that you follow these steps in order.
514

6-
Welcome to Kubernetes!
15+
- [Welcome](#welcome) - this page
16+
- [Prerequisites](#prerequisites) - things you need to complete before contributing
17+
- [Your First Contribution](first-contribution.md) - things you need to know before your first contribution
18+
- [Contributing](contributing.md) - the main guide with contributor information
19+
20+
## Resources Available
721

8-
- [Welcome](#welcome)
9-
- [Before you get started](getting-started.md)
10-
- [Your First Contribution](first-contribution.md)
11-
- [Contributing](contributing.md)
1222
- [Kubernetes Contributor Playground](#kubernetes-contributor-playground)
13-
- [Youtube playlist](#youtube-playlist)
23+
- [Contributor Workshops](#contributor-workshops)
1424
- [Community](#community)
1525
- [Communication](#communication-1)
1626
- [Events](#events)
1727
- [Meetups](#meetups)
1828
- [Mentorship](#mentorship)
1929
- [Advanced Topics](#advanced-topics)
2030

31+
# Prerequisites
32+
33+
Before submitting code to the project you should first take care of the following prerequisites.
34+
These steps are checked by a bot during your first submission, so doing these steps first will make your first contribution easier:
35+
36+
## Sign the CLA
37+
38+
Before you can contribute, you will need to sign the [Contributor License Agreement](/CLA.md).
39+
40+
## Code of Conduct
41+
42+
Please make sure to read and observe our [Code of Conduct](/code-of-conduct.md) and [Community Values](/values.md)
43+
44+
## Setting up your development environment
45+
46+
If you haven’t set up your environment, check the [developer resources](/contributors/devel/README.md#setting-up-your-dev-environment-coding-and-debugging).
47+
48+
## Community Expectations and Roles
49+
50+
Kubernetes is a community project.
51+
Consequently, it is wholly dependent on its community to provide a productive, friendly and collaborative environment.
52+
53+
- Read and review the [Community Expectations](expectations.md) for an understanding of code and review expectations.
54+
- See [Community Membership](/community-membership.md) for a list the various responsibilities of contributor roles. You are encouraged to move up this contributor ladder as you gain experience.
55+
2156
# Kubernetes Contributor Playground
2257

2358
If you are looking for a safe place, where you can familiarize yourself with (some of) the Kubernetes Project's review and pull request processes, then the [Kubernetes Contributor Playground](https://github.com/kubernetes-sigs/contributor-playground/) is the right place for you.
2459

25-
## Youtube playlist
60+
## Contributor Workshops
2661

2762
A [Youtube playlist](https://www.youtube.com/playlist?list=PL69nYSiGNLP3M5X7stuD7N4r3uP2PZQUx) of the New Contributor workshop has been posted, and an outline of the video content can be found [here](/events/2018/05-contributor-summit).
2863

@@ -50,6 +85,7 @@ You may also contact Paris Pittman via direct message on Kubernetes Slack (@pari
5085

5186
Please learn about our mentoring initiatives [here](http://git.k8s.io/community/mentoring/README.md).
5287
Feel free to ask us anything during our [Meet Our Contributors](https://github.com/kubernetes/community/blob/master/mentoring/programs/meet-our-contributors.md) to connect with us.
88+
5389
# Advanced Topics
5490

5591
This section includes things that need to be documented, but typical contributors do not need to interact with regularly.

contributors/guide/contributing.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ To check out code to work on, please refer to [the GitHub Workflow Guide](./gith
4343

4444
## Open a Pull Request
4545

46-
Pull requests are often called simply "PR".
46+
Pull requests are often called a "PR".
4747
Kubernetes generally follows the standard [github pull request](https://help.github.com/articles/about-pull-requests/) process, but there is a layer of additional kubernetes specific (and sometimes SIG specific) differences:
4848

4949
- [Kubernetes-specific github workflow](pull-requests.md#the-testing-and-merge-workflow).
@@ -56,7 +56,7 @@ Refer to its [command reference documentation](https://go.k8s.io/bot-commands).
5656

5757
Common new contributor PR issues are:
5858

59-
* not having correctly signed the CLA ahead of your first PR (see [Sign the CLA](/contributors/guide/getting-started.md#sign-the-cla) section)
59+
* not having correctly signed the CLA ahead of your first PR. See the [CLA page](/CLA.md) for troubleshooting help, in some cases you might need to file a ticket with the CNCF to resolve a CLA problem.
6060
* finding the right SIG or reviewer(s) for the PR (see [Code Review](#code-review) section) and following any SIG or repository specific contributing guidelines (see [Learn about SIGs](#learn-about-sigs) section)
6161
* dealing with test cases which fail on your PR, unrelated to the changes you introduce (see [Test Flakes](http://velodrome.k8s.io/dashboard/db/bigquery-metrics?orgId=1))
6262
* Not following [scalability good practices](scalability-good-practices.md)

contributors/guide/expectations.md

+20-24
Original file line numberDiff line numberDiff line change
@@ -6,34 +6,31 @@ description: |
66
community.
77
---
88

9-
Kubernetes is a community project. Consequently, it is wholly dependent on
10-
its community to provide a productive, friendly and collaborative environment.
9+
Kubernetes is a community project.
10+
Consequently, it is wholly dependent on its community to provide a productive, friendly and collaborative environment.
1111

1212
The first and foremost goal of the Kubernetes community is to develop orchestration
1313
technology that radically simplifies the process of creating reliable
14-
distributed systems. However a second, equally important goal is the creation
14+
distributed systems.
15+
However a second, equally important goal is the creation
1516
of a community that fosters easy, agile development of such orchestration
1617
systems.
1718

18-
We therefore describe the expectations for
19-
members of the Kubernetes community. This document is intended to be a living one
20-
that evolves as the community evolves via the same PR and code review process
21-
that shapes the rest of the project. It currently covers the expectations
22-
of conduct that govern all members of the community as well as the expectations
23-
around code review that govern all active contributors to Kubernetes.
19+
We therefore describe the expectations for members of the Kubernetes community.
20+
This document is intended to be a living one that evolves as the community evolves via the same PR and code review process that shapes the rest of the project.
21+
It currently covers the expectations of conduct that govern all members of the community as well as the expectations around code review that govern all active contributors to Kubernetes.
2422

2523
## Code review
2624

2725
As a community we believe in the value of code review for all contributions.
2826
Code review increases both the quality and readability of our codebase, which
2927
in turn produces high quality software.
3028

31-
See the [pull request documentation](/contributors/guide/pull-requests.md) for more information
32-
on code review.
29+
See the [pull request documentation](/contributors/guide/pull-requests.md) for more information on code review.
3330

3431
Consequently, as a community we expect that all active participants in the
35-
community will also be active reviewers. The
36-
[community membership](/community-membership.md) outlines the responsibilities
32+
community will also be active reviewers.
33+
The [community membership](/community-membership.md) outlines the responsibilities
3734
of the different contributor roles.
3835

3936
Expect reviewers to request that you avoid [common go style
@@ -44,27 +41,26 @@ mistakes](https://github.com/golang/go/wiki/CodeReviewComments) in your PRs.
4441
Because reviewers are often the first points of contact between new members of
4542
the community and can significantly impact the first impression of the
4643
Kubernetes community, reviewers are especially important in shaping the
47-
Kubernetes community. Reviewers are highly encouraged to review the
48-
[code of conduct](/governance.md#code-of-conduct) and are strongly
49-
encouraged to go above and beyond the code of conduct to promote a collaborative,
50-
respectful Kubernetes community.
44+
Kubernetes community.
45+
Reviewers are highly encouraged to not only abide by the [code of conduct](/governance.md#code-of-conduct) but are strongly encouraged to go above and beyond the code of conduct to promote a collaborative, respectful Kubernetes community.
5146

5247
## Expectations of reviewers: Review latency
5348

5449
Reviewers are expected to respond in a timely fashion to PRs that are assigned
55-
to them. Reviewers are expected to respond to an *active* PRs with reasonable
56-
latency, and if reviewers fail to respond, those PRs may be assigned to other
57-
reviewers.
50+
to them.
51+
Reviewers are expected to respond to an *active* PRs with reasonable latency, and if reviewers fail to respond, those PRs may be assigned to other reviewers.
5852

59-
If reviewers are unavailable to review for some time, they are expected to set their [user status](https://help.github.com/en/articles/personalizing-your-profile#setting-a-status) to "busy" so that the bot will not request reviews from them on new PRs automatically. If they are unavailable for a longer period of time, they are expected to remove themselves from the OWNERS file and potentially nominate someone else.
53+
If reviewers are unavailable to review for some time, they are expected to set their [user status](https://help.github.com/en/articles/personalizing-your-profile#setting-a-status) to "busy" so that the bot will not request reviews from them on new PRs automatically.
54+
If they are unavailable for a longer period of time, they are expected to remove themselves from the OWNERS file and potentially nominate someone else.
6055

6156
*Active* PRs are considered those which have a proper CLA (`cla:yes`) label
62-
and do not need rebase to be merged. PRs that do not have a proper CLA, or
63-
require a rebase are not considered active PRs.
57+
and do not need rebase to be merged.
58+
PRs that do not have a proper CLA, or require a rebase are not considered active PRs.
6459

6560
## Thanks
6661

6762
Many thanks in advance to everyone who contributes their time and effort to
6863
making Kubernetes both a successful system as well as a successful community.
6964
The strength of our software shines in the strengths of each individual
70-
community member. Thanks!
65+
community member.
66+
Thanks!

contributors/guide/first-contribution.md

+7-17
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,6 @@ description: |
1717
- [SIG-specific contributing guidelines](#sig-specific-contributing-guidelines)
1818
- [File an Issue](#file-an-issue)
1919

20-
21-
Have you ever wanted to contribute to the coolest cloud technology?
22-
We will help you understand the organization of the Kubernetes project and direct you to the best places to get started.
23-
You'll be able to pick up issues, write code to fix them, and get your work reviewed and merged.
24-
25-
Please be aware that due to the large number of issues our triage team deals with, we cannot offer technical support in GitHub issues.
26-
If you have questions about the development process, feel free to jump into our [Slack Channel](http://slack.k8s.io/) or join our [mailing list](https://groups.google.com/forum/#!forum/kubernetes-dev).
27-
You can also ask questions on [ServerFault](https://serverfault.com/questions/tagged/kubernetes) or [Stack Overflow](https://stackoverflow.com/questions/tagged/kubernetes).
28-
The Kubernetes team scans Stack Overflow on a regular basis and will try to ensure your questions don't go unanswered.
29-
3020
## Find something to work on
3121

3222
Help is always welcome! For example, documentation (like the text you are reading now) can always use improvement.
@@ -43,8 +33,6 @@ There are [multiple repositories](https://github.com/kubernetes/) within the Kub
4333
Each repository has beginner-friendly issues that provide a good first issue.
4434
For example, [kubernetes/kubernetes](https://git.k8s.io/kubernetes) has [help wanted](https://go.k8s.io/help-wanted) and [good first issue](https://go.k8s.io/good-first-issue) labels for issues that should not need deep knowledge of the system.
4535
The `good first issue` label indicates that members have committed to providing [extra assistance](/contributors/guide/help-wanted.md) for new contributors.
46-
<!-- TODO: review removing this note after 3 months or after the 1.12 release -->
47-
Please note that while several of the repositories in the Kubernetes community have `good first issue` labels already, they are still being applied throughout the community.
4836

4937
Another good strategy is to find a documentation improvement, such as a missing/broken link, which will give you exposure to the code submission/review process without the added complication of technical depth. Please see [Contributing](#contributing) below for the workflow.
5038

@@ -55,16 +43,18 @@ then the robot will assign the issue to you and your name will present at `Assig
5543

5644
### Learn about SIGs
5745

58-
#### SIG structure
59-
60-
You may have noticed that some repositories in the Kubernetes Organization are owned by Special Interest Groups, or SIGs.
46+
You may have noticed that some repositories in the Kubernetes Organization are owned by [Special Interest Groups](/sig-list.md), or SIGs.
6147
We organize the community into SIGs in order to improve our workflow and more easily manage what is a very large community project.
62-
The developers within each SIG have autonomy and ownership over that SIG's part of Kubernetes.
48+
The developers within each SIG have autonomy and ownership over that SIG's part of Kubernetes. Check out the [list of SIGs](/sig-list.md) for contact information.
49+
50+
Understanding how to interact with SIGs is an important part of contributing.
51+
52+
#### SIG structure
6353

6454
A SIG is an open, community effort.
6555
Anybody is welcome to jump into a SIG and begin fixing issues, critiquing design proposals and reviewing code.
6656
SIGs have regular [video meetings](https://kubernetes.io/community/) which everyone is welcome to.
67-
Each SIG has a slack channel that you can join as well.
57+
Each SIG has a slack channel, meeting notes, and their own documentation that is useful to read and understand.
6858

6959
There is an entire SIG ([sig-contributor-experience](/sig-contributor-experience/README.md)) devoted to improving your experience as a contributor.
7060
Contributing to Kubernetes should be easy.

contributors/guide/getting-started.md

-36
This file was deleted.

0 commit comments

Comments
 (0)