Skip to content

Merge getting started into the main page as they're required. #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Merge getting started into the main page as they're required. #4876

merged 1 commit into from
Jun 23, 2020

Conversation

castrojo
Copy link
Member

Restructure the main menu, fix up formatting.

This is part of fixing #4444 - I've merged the getting started into the main readme and just called it prerequisites since everyone has to do them let's just put them in the top level. I've deduped some things and also fixed up some formatting.

I wanted to get a review first before I dive into removing the overlap between the pr doc and the contributing doc, so consider this the first step.

Signed-off-by: Jorge O. Castro [email protected]

/hold

Restructure the main menu, fix up formatting.

Signed-off-by: Jorge O. Castro <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 22, 2020
@castrojo castrojo requested a review from mrbobbytables June 22, 2020 16:10
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/contributor-guide Issues or PRs related to the contributor guide approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Jun 22, 2020
@castrojo castrojo marked this pull request as draft June 22, 2020 16:11
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2020
@mrbobbytables
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2020
@castrojo
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2020
@castrojo castrojo removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2020
@mrbobbytables mrbobbytables marked this pull request as ready for review June 23, 2020 21:08
@k8s-ci-robot k8s-ci-robot merged commit 46bd935 into kubernetes:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants