Skip to content

Inputs for CONTRIBUTING.md #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VineethReddy02 opened this issue Jun 20, 2018 · 7 comments
Closed

Inputs for CONTRIBUTING.md #2293

VineethReddy02 opened this issue Jun 20, 2018 · 7 comments
Labels
area/contributor-guide Issues or PRs related to the contributor guide lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.

Comments

@VineethReddy02
Copy link

Contributing page would be a great entry point for beginners in getting started with there respective interest groups.

These following are some of the basic elements of a contributing page, feel free to add more.

  • Before you begin
  • Adopting an issue
  • Bug lifecycle
    1)Filing a bug
    2)Sending a fix
  • Feature Request
  • Feature lifecycle
  • Merge state meanings
  • Use of @Meanings

Or else we will at least have pointer to generalized contributing page
https://github.com/kubernetes/community/blob/master/contributors/guide/README.md

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 20, 2018
@VineethReddy02
Copy link
Author

/area contributor-guide
/sig autoscaling

@k8s-ci-robot k8s-ci-robot added area/contributor-guide Issues or PRs related to the contributor guide sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 20, 2018
@nikhita
Copy link
Member

nikhita commented Jun 24, 2018

I guess @VineethReddy02 created this issue for #1832 but since the README already mentions the contributor guide, is it overkill to have a CONTRIBUTING.md for this repo? This would just create an extra file with a link.

/cc @guineveresaenger @castrojo

@castrojo
Copy link
Member

I think creating a link is the way to go, if we kept stuff in contributing.md then that'd be one more file we'd have to check when fixing something.

@parispittman
Copy link
Contributor

@VineethReddy02 would you like to put a help wanted label on this and see if we can get a contributor to do what @castrojo is suggesting? Or do you have a different direction in mind?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 21, 2018
@nikhita
Copy link
Member

nikhita commented Nov 21, 2018

We have a CONTRIBUTING.md file which has links to the contributor guide and other useful resources.

Closing. Please reopen if needed.
/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closing this issue.

In response to this:

We have a CONTRIBUTING.md file which has links to the contributor guide and other useful resources.

Closing. Please reopen if needed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/contributor-guide Issues or PRs related to the contributor guide lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Projects
None yet
Development

No branches or pull requests

6 participants