Skip to content

Disambiguate "design-proposals" and accepted designs #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikedanese opened this issue Aug 15, 2017 · 13 comments
Closed

Disambiguate "design-proposals" and accepted designs #914

mikedanese opened this issue Aug 15, 2017 · 13 comments
Labels
area/enhancements Issues or PRs related to the Enhancements subproject lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.

Comments

@mikedanese
Copy link
Member

mikedanese commented Aug 15, 2017

This came up in a sig. Someone asked whether a merged doc in contributors/design-proposals/ was an accepted design or still a proposal.

  • Is there documentation anywhere explaining that merged docs are accepted?
  • Would contributors/designs/ be a better name for the contributors/design-proposals/? Are docs proposals when they are PRs and become designs after they merge?
  • If not, then when should a design proposal graduate to design? After implementation? Should the doc move at that point?
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 15, 2017
@cblecker cblecker added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Aug 16, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 16, 2017
@bgrant0607
Copy link
Member

This is being discussed in SIG Architecture as we formalize the proposal process.

Related: #651

@grodrigues3
Copy link
Contributor

grodrigues3 commented Aug 17, 2017

@kubernetes/sig-architecture-feature-requests

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 18, 2018
@bgrant0607
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2018
@bgrant0607 bgrant0607 self-assigned this Jan 19, 2018
@bgrant0607
Copy link
Member

Almost all of these were written prior to implementation and so are "proposals" in that sense. A few were never implemented -- those should be marked, and possibly moved.

In general, we're trying to clarify this type of thing with the new KEP process.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2018
@bgrant0607 bgrant0607 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2018
@bgrant0607 bgrant0607 removed their assignment Apr 24, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2018
@bgrant0607 bgrant0607 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 23, 2018
@rhuss
Copy link
Contributor

rhuss commented Sep 20, 2018

We have a similar question, especially for this accepted design proposal for service discovery by @KurtStam --> https://github.com/kubernetes/community/blob/master/contributors/design-proposals/network/service-discovery.md

This proposal introduces new annotations with a prefix "api.service.kubernetes.io/" (e.g. "api.service.kubernetes.io/description-path"). As this is an accepted design proposal (but not implemented, however there is very likely no implementation, just that spec), is it safe to assume that these annotations can be safely used in applications and tooling ?

That open the general question whether there is a comprehensive list of "official" and reservied annotations. Afaik there is none, the only pointers I found were https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints and the one mentioned within https://kubernetes.io/docs/concepts/services-networking/service.

@justaugustus
Copy link
Member

/sig pm

@nikhita
Copy link
Member

nikhita commented May 3, 2019

Someone asked whether a merged doc in contributors/design-proposals/ was an accepted design or still a proposal.

@justaugustus is this still relevant given that we have the KEP status field today?

@mrbobbytables
Copy link
Member

Closing this as it is no longer relevant with the KEP process 👍
/close

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Closing this issue.

In response to this:

Closing this as it is no longer relevant with the KEP process 👍
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

/remove-sig pm
/sig architecture
/area enhancements

@k8s-ci-robot k8s-ci-robot added the area/enhancements Issues or PRs related to the Enhancements subproject label Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/enhancements Issues or PRs related to the Enhancements subproject lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
None yet
Development

No branches or pull requests