Skip to content

Propose KEP template #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2017
Merged

Propose KEP template #1124

merged 3 commits into from
Sep 26, 2017

Conversation

calebamiles
Copy link
Contributor

@calebamiles calebamiles commented Sep 25, 2017 •
edited
Loading

Propose a template for the KEP process

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2017
@calebamiles calebamiles force-pushed the propose-kep-template branch 2 times, most recently from 6e07eb8 to 6dd34b9 Compare September 25, 2017 04:41
@k8s-ci-robot k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 25, 2017
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 25, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 25, 2017
@calebamiles calebamiles changed the title Propose kep template Propose KEP template Sep 25, 2017
@calebamiles calebamiles added committee/steering Denotes an issue or PR intended to be handled by the steering committee. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/pm sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 25, 2017
bgrant0607
bgrant0607 reviewed Sep 25, 2017
View reviewed changes
contributors/design-proposals/kep-template.md Outdated
preferably in a mailing list so that the discussion is saved for future Kubernauts.


### Section: Metadata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This nesting is confusing. I was expecting a template that could be copied and filled in.

Copy link
Contributor Author

@calebamiles calebamiles Sep 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted empty template from section explanations. I agree that the nesting was confusing and let me know if extracting an empty template doesn't help

bgrant0607
bgrant0607 reviewed Sep 25, 2017
View reviewed changes
contributors/design-proposals/kep-template.md Outdated
The `Examples` section should describe the intended user experience for an
KEP.

### Section: How Do I Teach This?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is intended to be in this section?

bgrant0607
bgrant0607 reviewed Sep 25, 2017
View reviewed changes
contributors/design-proposals/kep-template.md Outdated
will be the primary description of use cases
- `Requirements` is replaced by `Detailed Design` within a KEP

[design template]: https://github.com/pwittrock/community/blob/design/contributors/design-proposals/api-proposal-design-template.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with making a separate (sub-)template specific to API changes.

calebamiles added a commit to calebamiles/community that referenced this pull request Sep 26, 2017
@calebamiles
address comments
6dca8c2 
from @bgrant0607:
- kubernetes#1124 (comment)
- kubernetes#1124 (comment)
- kubernetes#1124 (comment)
@calebamiles calebamiles added the kind/design Categorizes issue or PR as related to design. label Sep 26, 2017
@bgrant0607 bgrant0607 assigned bgrant0607 and unassigned jbeda and thockin Sep 26, 2017
@bgrant0607
Copy link
Member

I think this is at a good place to checkpoint and iterate further, so I'm going to merge.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue. .

@k8s-github-robot k8s-github-robot merged commit cfac9e3 into kubernetes:master Sep 26, 2017
erinboyd pushed a commit to erinboyd/community that referenced this pull request Oct 23, 2017
@calebamiles
address comments
f6f2add 
from @bgrant0607:
- kubernetes#1124 (comment)
- kubernetes#1124 (comment)
- kubernetes#1124 (comment)
erinboyd pushed a commit to erinboyd/community that referenced this pull request Oct 23, 2017
@calebamiles
address comments
0e3405c 
from @bgrant0607:
- kubernetes#1124 (comment)
- kubernetes#1124 (comment)
- kubernetes#1124 (comment)
justaugustus pushed a commit to justaugustus/enhancements that referenced this pull request Sep 3, 2018
@calebamiles
address comments
11e1372 
from @bgrant0607:
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
@justaugustus
Copy link
Member

/remove-sig pm
/sig architecture
/area enhancements

@k8s-ci-robot k8s-ci-robot added area/enhancements Issues or PRs related to the Enhancements subproject and removed sig/pm labels Apr 19, 2020
MadhavJivrajani pushed a commit to MadhavJivrajani/community that referenced this pull request Nov 30, 2021
Merge pull request kubernetes#1124 from calebamiles/propose-kep-template
5e0cf2f 
Automatic merge from submit-queue. .

Propose KEP template

Propose a template for the [KEP process][]


[KEP process]: kubernetes#967
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Nov 30, 2021
@calebamiles
address comments
49f8e76 
from @bgrant0607:
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Nov 30, 2021
@calebamiles @MadhavJivrajani
address comments
8e011c1 
from @bgrant0607:
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this pull request Dec 1, 2021
@calebamiles @MadhavJivrajani
address comments
b7c7c33 
from @bgrant0607:
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this pull request Dec 1, 2021
@calebamiles @MadhavJivrajani
address comments
1cf316f 
from @bgrant0607:
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this pull request Dec 1, 2021
@calebamiles
address comments
7262146 
from @bgrant0607:
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Dec 1, 2021
@calebamiles
address comments
238d584 
from @bgrant0607:
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Dec 1, 2021
@calebamiles
address comments
0bf74fd 
from @bgrant0607:
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
- kubernetes/community#1124 (comment)
danehans pushed a commit to danehans/community that referenced this pull request Jul 18, 2023
@istio-testing
Automator: update common-files@master in istio/community@master (kube…
913ec71 
…rnetes#1124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrant0607 bgrant0607 bgrant0607 left review comments

@philips philips Awaiting requested review from philips

@jbeda jbeda Awaiting requested review from jbeda

@jdumars jdumars Awaiting requested review from jdumars

@pwittrock pwittrock Awaiting requested review from pwittrock

@thockin thockin Awaiting requested review from thockin

@radhikapc radhikapc Awaiting requested review from radhikapc

@Bradamant3 Bradamant3 Awaiting requested review from Bradamant3

Assignees

@bgrant0607 bgrant0607

Labels
area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@calebamiles @k8s-ci-robot @bgrant0607 @k8s-github-robot @justaugustus @jbeda @thockin