Skip to content

Add gcepd and filestore csi drivers to sig-gcp projects #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2018
Merged

Add gcepd and filestore csi drivers to sig-gcp projects #2361

merged 1 commit into from
Aug 3, 2018

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Jul 9, 2018 •
edited
Loading

Fixes #2463

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/gcp labels Jul 9, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2018
@msau42
Copy link
Member Author

msau42 commented Jul 9, 2018

cc @davidz627

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2018
@davidz627
Copy link
Contributor

AFAIK sig-gcp has been disbanded and replaced by sig-cloudprovider-gcp

@msau42
Copy link
Member Author

msau42 commented Jul 9, 2018

The only other place currently is the sig-cloud-provider page, which lists all the cloud provider subprojects. But I'm not sure if that's a great place to list the csi drivers. cc @abgworrall for guidance

@msau42
Copy link
Member Author

msau42 commented Aug 3, 2018

/assign @spiffxp

@saad-ali
Copy link
Member

saad-ali commented Aug 3, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2018
@spiffxp
Copy link
Member

spiffxp commented Aug 3, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit f4e322f into kubernetes:master Aug 3, 2018
@msau42 msau42 deleted the update-gcp branch November 17, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abgworrall abgworrall Awaiting requested review from abgworrall

@castrojo castrojo Awaiting requested review from castrojo

Assignees

@spiffxp spiffxp

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msau42 @davidz627 @saad-ali @spiffxp @k8s-ci-robot