Skip to content

Add wg-k8s-infra with draft charter #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2019
Merged

Add wg-k8s-infra with draft charter #2830

merged 3 commits into from
Jan 11, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Oct 19, 2018 •
edited
Loading

There are some TODO's around renaming external assets from
k8s-infra-team to wg-k8s-infra, but I think that can be done
in a follow up PR. My main concern here is whether the
charter looks good enough to move forward

Listing as WIP while I see how this aligns with the current corpus of WG
docs from steering.

Fixes #2715

Content pulled from: https://docs.google.com/document/d/1zLh-YkLN3P09yyQf534VJCmiYUcqezh7HRHKyf7CenQ/edit

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 19, 2018
@spiffxp spiffxp mentioned this pull request Oct 19, 2018
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Oct 19, 2018

/sig testing
/sig contributor-experience
/sig architecture
/sig release
As the SIGs that I think this WG cuts across

/committee steering
To sanity check the WG stuff

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. committee/steering Denotes an issue or PR intended to be handled by the steering committee. labels Oct 19, 2018
@cblecker
Copy link
Member

/cc

@k8s-ci-robot k8s-ci-robot requested a review from cblecker October 19, 2018 22:26
@spiffxp
Copy link
Member Author

spiffxp commented Oct 19, 2018

/cc @dims @thockin @brendandburns @BenTheElder @ixdy

@thockin
Copy link
Member

thockin commented Oct 22, 2018

/lgtm

@dims
Copy link
Member

dims commented Oct 22, 2018

Looks great! thanks @spiffxp

thockin
thockin reviewed Oct 22, 2018
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 22, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Oct 22, 2018

/hold
mostly testing whether k8s-ci-robot is responding now

@spiffxp spiffxp changed the title [wip] Add wg-k8s-infra with draft charter Add wg-k8s-infra with draft charter Oct 22, 2018
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 10, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Jan 10, 2019

Charter's been rebased, I squashed the previous commits. Now looking at changes necessary to address steering concerns

@bgrant0607
Copy link
Member

LGTM. Thanks for the changes, @spiffxp

@dims
Copy link
Member

dims commented Jan 11, 2019

LGTM @spiffxp

@spiffxp
Copy link
Member Author

spiffxp commented Jan 11, 2019

Sounds like this is ready for a proper /lgtm, I'll remove the /hold when I get one

BenTheElder
BenTheElder approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2019
idvoretskyi
idvoretskyi approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, idvoretskyi, jdumars, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cblecker,idvoretskyi,jdumars,spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Jan 11, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6d7d04d into kubernetes:master Jan 11, 2019
@spiffxp spiffxp deleted the wg-k8s-infra branch January 12, 2019 02:50
@spiffxp
Copy link
Member Author

spiffxp commented Jan 16, 2019

/wg k8s-infra

@spiffxp spiffxp mentioned this pull request Jan 16, 2019
Closed
@philips
Copy link
Contributor

philips commented Jan 16, 2019

LGTM

1 similar comment
@dims
Copy link
Member

dims commented Jan 16, 2019

LGTM

@pwittrock
Copy link
Member

/lgtm

3 similar comments
@smarterclayton
Copy link
Contributor

/lgtm

@jbeda
Copy link
Contributor

jbeda commented Jan 16, 2019

/lgtm

@derekwaynecarr
Copy link
Member

/lgtm

@spiffxp
Copy link
Member Author

spiffxp commented Jan 16, 2019

Context: https://groups.google.com/a/kubernetes.io/d/msg/steering/FC7bblZLZ_I/HxK1zo-OCwAJ

I forgot to get written LGTMs from steering committee and asked for them retroactively. There are now LGTMs from a simple majority of the steering committee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@timothysc timothysc timothysc left review comments

@thockin thockin thockin left review comments

@ixdy ixdy ixdy left review comments

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@BenTheElder BenTheElder BenTheElder approved these changes

@jdumars jdumars jdumars approved these changes

@cblecker cblecker cblecker approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@dims dims

@idvoretskyi idvoretskyi

@BenTheElder BenTheElder

@jdumars jdumars

@cblecker cblecker

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.