Skip to content

Add stakeholder SIGs for wg-iot-edge #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

zjs
Copy link
Contributor

@zjs zjs commented Mar 21, 2019

Add SIG Multicluster and SIG Networking as the stakeholder SIGs for the IoT Edge working group based on the working group's README.

Towards #2176.

/kind documentation
/sig contributor-experience
/wg iot-edge
/cc @CindyXing @dejanb @ptone @cantbewong

Add SIG Multicluster and SIG Networking as the stakeholder SIGs for the
IoT Edge working group based on the working group's README.
@k8s-ci-robot
Copy link
Contributor

@zjs: GitHub didn't allow me to request PR reviews from the following users: cindyxing, dejanb, ptone, cantbewong.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Add SIG Multicluster and SIG Networking as the stakeholder SIGs for the IoT Edge working group based on the working group's README.

Towards #2176.

/kind documentation
/sig contributor-experience
/wg iot-edge
/cc @CindyXing @dejanb @ptone @cantbewong

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. wg/iot-edge Categorizes an issue or PR as relevant to WG IOT Edge. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @zjs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2019
@nikhita
Copy link
Member

nikhita commented Mar 21, 2019

/assign @CindyXing @dejanb @ptone @cantbewong
/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@nikhita: GitHub didn't allow me to assign the following users: CindyXing, dejanb, ptone, cantbewong.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @CindyXing @dejanb @ptone @cantbewong
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2019
Copy link
Contributor

@CindyXing CindyXing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the change. Thanks.

@nikhita
Copy link
Member

nikhita commented Mar 23, 2019

Adding lgtm since @CindyXing is the wg lead.
/lgtm

/assign @idvoretskyi
could you approve?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2019
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CindyXing, idvoretskyi, zjs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6b27331 into kubernetes:master Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/iot-edge Categorizes an issue or PR as relevant to WG IOT Edge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants