Skip to content

Draft-Revision of Issue Triage page #4744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 75 commits into from
May 21, 2020
Merged

Draft-Revision of Issue Triage page #4744

merged 75 commits into from
May 21, 2020

Conversation

lasomethingsomething
Copy link
Contributor

@lasomethingsomething lasomethingsomething commented Apr 25, 2020

I've shared this draft in the #contribex channel and gotten some feedback.

A few highlights:

  • Tools section that mentions Gubernator, Project Boards, DevStats, etc.
  • Process Pointers from SIGs on how to run triage sessions
  • step-by-step flow (there might be better ways to capture the order of numbered steps)
  • ToC

This draft does not include points made in the recently merged Issue Triage Workflow and Automation KEP, so the next step would be to integrate key portions into the guide pending feedback and suggestions.

ref #4743

@mrbobbytables
Copy link
Member

/assign

Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few little things, but overall should be ready :)


We suggest preparing your triage by filtering out the oldest, unlabelled issues and/or pull requests first.

## Step Two: Triage Issues by Type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get this in there, Id merge as is and we can revisit when the label change goes through.

@lasomethingsomething
Copy link
Contributor Author

/assign @mrbobbytables

@mrbobbytables
Copy link
Member

Thanks @LappleApple :) I know there have been ALOT of changes and edits, but you sticking with it is very much appreciated 👍
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LappleApple, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@lasomethingsomething
Copy link
Contributor Author

@mrbobbytables It was good! No complaints.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LappleApple thanks, and great job! Few comments inline. (I feel the doc is now little long but that should be fine:)) Thanks!

@spzala
Copy link
Member

spzala commented May 21, 2020

@LappleApple thanks for addressing my comments!
/lgtm
As @mrbobbytables mentioned, I am good with merging this PR and make changes related to triage labels separately when the related work is done.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0a03527 into kubernetes:master May 21, 2020
@lasomethingsomething
Copy link
Contributor Author

@spzala You've got excellent copy editing skills :)

@spzala
Copy link
Member

spzala commented May 21, 2020

@LappleApple 👍 :) thanks! and great job again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants