-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add frontmatter descriptions to the contributor guide docs #4870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frontmatter descriptions to the contributor guide docs #4870
Conversation
--- | ||
title: "Contributors Guide" | ||
weight: 1 | ||
slug: "guide" | ||
--- | ||
|
||
<!-- | ||
Contributing to this document? | ||
Please use semantic line feeds for readability: http://rhodesmill.org/brandon/2012/one-sentence-per-line/ | ||
--> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page is no longer being included and our current practice is to word wrap at 80 characters following the style guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great! Had a couple of comments as an aside that we should probably address in a different PR.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrbobbytables, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f932da2
to
427ccfb
Compare
/lgtm |
/hold cancel |
The descriptions will be used on list pages within the contributor site to give a brief overview of the pages 👍
/hold for review
ref: #4444