-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Deduplify content: Remove reviewee content from the review-guidelines #5031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
reorganize pull request page. Signed-off-by: Jorge O. Castro <[email protected]>
/assign mrbobbytables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes and a few ideas, but overall does a good job of deduping 👍
Signed-off-by: Jorge O. Castro <[email protected]>
/lgtm |
it would be cool if the reviewer guidelines was turned into a checklist something like
etc |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: castrojo, markyjackson-taulia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@parispittman there are a few items we want to add in a follow-up PR, would it be okay if those are added then? |
discussed, we are good \o/ - changes will follow up in later PR. |
reorganize pull request page.
The review-guidelines.md had duplicate content from pull-requests.md. I've removed it so that the review guidelines only have things useful to reviewers and pull-requests.md now has all the tips for getting a good review in one place.
The nitty gritty details of how prow/tide merges PRs is useful, but not so much when you're doing a PR, so I moved it to the bottom of the document so that the PR tips and best practices are listed before them.
And lastly I reformatted pull-requests.md to remove the confusing numerals (they'll look better in the ToC on the contributor site this way and also reformatted it with semantic line feeds, so sorry for the noise there.
Signed-off-by: Jorge O. Castro [email protected]
Which issue(s) this PR fixes:
fixes: #4444