Skip to content

Move testing-commons subproject to best-effort #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jan 27, 2021

After discussion with current testing-commons subproject owners
@alejandrox1 and @andrewsykim we have decided to move the
testing-commons subproject to best-effort.

It is important that we have oversight of kubernetes/kubernetes tests,
but folks now lack the bandwidth to consistently set and drive an agenda
in this area.

Best-effort means we are stopping the testing-commons meeting and
archiving the testing-commons slack channel, and ask those contributors
interested in this topic to bring discussion to the sig-testing meeting
and sig-testing slack channel.

While I was here, I went ahead and moved sig-testing related slack
config into its own directory.

/hold
for lazy consensus, deadline 3pm PT Friday (kubernetes-sig-testing@ thread)
/cc @BenTheElder @stevekuznetsov
for sig-testing approval
/cc @alejandrox1 @andrewsykim
for current subproject owner approval

FYI @kubernetes/steering

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 27, 2021
@spiffxp spiffxp force-pushed the best-effort-testing-commons branch from 61c86a2 to 167ad0c Compare January 27, 2021 21:55
@spiffxp
Copy link
Member Author

spiffxp commented Jan 27, 2021

/cc @mrbobbytables @coderanger
for any opinions on the slack config changes

@spiffxp
Copy link
Member Author

spiffxp commented Jan 27, 2021

post-merge TODO:

  • remove testing-commons meeting from zoom
  • remove testing-commons meeting from sig-testing calendar

done

@spiffxp
Copy link
Member Author

spiffxp commented Feb 1, 2021

/hold cancel
lazy consensus deadline has passed

I've removed the testing-commons meeting from zoom and sig-testing's calendar

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2021
@BenTheElder
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2021
Copy link
Contributor

@alejandrox1 alejandrox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spiffxp
Copy link
Member Author

spiffxp commented Feb 5, 2021

/assign @cblecker @nikhita @mrbobbytables @alisondy
for /approve

Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold
for explicit review by slack admins. @mrbobbytables @coderanger can you take a look?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2021
@mrbobbytables
Copy link
Member

/lgtm

@spiffxp
Copy link
Member Author

spiffxp commented Feb 8, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4b9507d into kubernetes:master Feb 8, 2021
@spiffxp spiffxp deleted the best-effort-testing-commons branch February 8, 2021 22:33
@spiffxp
Copy link
Member Author

spiffxp commented Feb 9, 2021

Also closed the testing-commons project board: https://github.com/orgs/kubernetes/projects/44

@spiffxp spiffxp added this to the v1.21 milestone Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants