Skip to content

Record-keeping updates related to sig-security-tooling #5941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PushkarJ
Copy link
Member

Record keeping updates for sig-security-tooling:

  • Added OWNERS file
  • Updated sigs.yaml
  • Generated README.md from sigs.yaml

/sig security
/assign @IanColdwater @tabbysable

@k8s-ci-robot k8s-ci-robot added sig/security Categorizes an issue or PR as relevant to SIG Security. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2021
@tabbysable
Copy link
Member

You love to see it!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
@PushkarJ
Copy link
Member Author

/assign @liggitt, post review from Tabby as per the k8s-ci-bot instructions.

@PushkarJ PushkarJ force-pushed the record-keeping-sig-sec-tooling branch from 440d595 to e030593 Compare August 12, 2021 17:35
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
- Added OWNERS file
- Updated sigs.yaml
- Generated README.md from sigs.yaml

- Removed mailing list and added leads as approvers
@PushkarJ PushkarJ force-pushed the record-keeping-sig-sec-tooling branch from e030593 to 718337e Compare August 12, 2021 17:36
@PushkarJ
Copy link
Member Author

@liggitt removed mailing list and added @kubernetes/sig-security-leads as approvers. Need /lgtm and /approve if no further feedback

@liggitt
Copy link
Member

liggitt commented Aug 12, 2021

thanks for the update.

/approve

will defer lgtm to sig-security leads

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, PushkarJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@tabbysable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
@PushkarJ
Copy link
Member Author

Thank you for the reviews Jordan and Tabby!!

@k8s-ci-robot k8s-ci-robot merged commit d57bf59 into kubernetes:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/security Categorizes an issue or PR as relevant to SIG Security. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants