Proposal: support multi-fields merge key #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
mengqiy
force-pushed
the
multi_fields_merge_keys
branch
from
a8a2ae2 to
4766413
Compare
|
/assign @pwittrock @liggitt |
mengqiy
changed the title
pwittrock
reviewed
May 10, 2017
| If a merge key only has one field, it will be the same as before, i.e. `patchMergeKey:"<key1>"`. | ||
|
|
||
| There are no patch format changes. | ||
| Additional fields are just extra fields in the patch. |
There was a problem hiding this comment.
Additional fields are just extra fields in the patch.
Patches for fields that have multiple fields in the merge key must include all of the fields part of the mergekey in the patch.
pwittrock
reviewed
May 10, 2017
| If a merge key only has one field, it will be the same as before, i.e. `patchMergeKey:"<key1>"`. | ||
|
|
||
| There are no patch format changes. | ||
| Additional fields are just extra fields in the patch. |
There was a problem hiding this comment.
What is the behavior if any of the fields are missing from the patch? Does the server reject the request?
There was a problem hiding this comment.
We should reject that patch when it happens to a new API using multi-fields merge key.
Updated.
|
Alright, I think this has been discussed enough in the other PR, and there have been no objections. I am going to merge it. FYI: @liggitt @fabianofranz @adohe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @pwittrock suggested, break #476 to 2 proposals: