validate emails .... #8377
validate emails .... #8377
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/S
|
Ok good, this now fails on the currently mismatched and/or missing emails: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/community/8377/pull-community-verify/1899592384602181632 |
…th de-normalized person entries
these leads had emails set but not the same across all positions, reconciled them (Note TODO about data format ...)
confirmed with them in slack
k8s-ci-robot
added
size/M
| @@ -3995,7 +4008,7 @@ committees: | |||
| - github: aojea | |||
| name: Antonio Ojea | |||
| company: Google | |||
| email: antonio.ojea.garcia@gmail.com | |||
| email: aojea@google.com | |||
There was a problem hiding this comment.
@aojea this was the one set the most for you, and the oldest one, but we can update it to either (just need it to be the same for all so we don't duplicate to CNCF)
The rest of these were only "inconsistent" for having empty values.
| @@ -3382,6 +3387,7 @@ sigs: | |||
| - github: marosset | |||
| name: Mark Rossetti | |||
| company: Microsoft | |||
| email: [email protected] | |||
There was a problem hiding this comment.
confirmed with @marosset in slack
aside from marosset and aojea, all others are just filling in empty fields to match existing entries for other groups
ideally we would dedupe the person entries entirely, but that's a larger PR, and they're usually duplicated at most a few times ...
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm for me |
|
we might need to update Lines 3 to 6 in 1eefeb5 |
|
cc @kubernetes/sig-contributor-experience-leads |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold-cancel |
|
LGTM – changes for enforcing setting email Also, re: #8377 (comment) I'll discuss it among contribex leads and will follow up with a PR (most likely, will add contrbex leads alias to start with) |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| // non-emeritus must have email and company set | ||
| if prefix != "emeritus_lead" { | ||
| // email must be set and consistent | ||
| if val.Email == "" { |
And add a TODO about awkward data format with de-normalized person entries.
TODO: once I've confirmed that CI fails with the first commit, fix inconsistent entries in a second commit.
Refer to kubernetes/steering#281
Which issue(s) this PR fixes:
Fixes #